feat: Show explainer note when step decreases due to benchmark increase#321
Open
feat: Show explainer note when step decreases due to benchmark increase#321
Conversation
When employees view their salary history and a step decreased while the benchmark factor increased (releveling), show an italicized info note explaining that the benchmark change updated expectations and this isn't a bad sign. Also adds demo data with a releveling scenario for local testing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When we increase a benchmark, some employees get releveled, which can result in their step decreasing even though they got a raise. This can be confusing when employees view their own salary history — seeing a step go down looks like a bad sign when it isn't.
Changes
previousSalaryprop toSalaryHistoryCardand builds a chronological map in the employee page to pass it throughgenerateDemoData.tswith a releveling scenario (benchmark 1.0→1.15, step 0.8→0.6, salary still increased) for local testingHow did you test this code?
This was authored by an AI agent. The demo data can be used to verify the behavior locally by logging in as dev@posthog.com and viewing the employee's salary history.
🤖 LLM context
Co-authored with Claude Code (Opus 4.6).