Skip to content

test: Fix test repos using git commit signing if global commit signing is enabled#1462

Merged
charlesvien merged 1 commit intomainfrom
ryan/fix_test_signing
Apr 2, 2026
Merged

test: Fix test repos using git commit signing if global commit signing is enabled#1462
charlesvien merged 1 commit intomainfrom
ryan/fix_test_signing

Conversation

@ryans-posthog
Copy link
Copy Markdown
Contributor

Problem

Currently, if global commit signing is enabled for git, the tests require authorizing many commits manually, usually through a UI pop up with a fingerprint authorization.

Changes

Disables the commitsign git configuration option when creating the test repository.

How did you test this?

Run tests locally with commit signing enabled globally and verify that no commit signing requests occur.

Copy link
Copy Markdown
Member

@charlesvien charlesvien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@charlesvien charlesvien merged commit 46c330b into main Apr 2, 2026
15 checks passed
@charlesvien charlesvien deleted the ryan/fix_test_signing branch April 2, 2026 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants