-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Add release notification workflow #1457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+16
−0
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| name: Release PostHog Code to Discord | ||
|
|
||
| on: | ||
| release: | ||
| types: [published] | ||
|
|
||
| # No GITHUB_TOKEN permissions needed -- only calls an external webhook | ||
| permissions: {} | ||
|
|
||
| jobs: | ||
| notify: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: SethCohen/github-releases-to-discord@37afa88c8c9302a9307244b5a0d4e782d528a4b5 # v1.15.1 | ||
| with: | ||
| webhook_url: ${{ secrets.DISCORD_RELEASE_WEBHOOK_URL }} | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Copilot Autofix
AI about 7 hours ago
In general, the fix is to explicitly declare
permissionsfor the workflow/job so that theGITHUB_TOKENhas the least privilege required. Since this workflow only posts to Discord using a secret and does not need to modify repository contents, a minimalpermissionsblock grantingcontents: read(or evenpermissions: {}if no GitHub API access is needed) is appropriate.The best minimally invasive fix is to add a
permissionsblock to thenotifyjob in.github/workflows/code-discord-release.yml. Place it underruns-on: ubuntu-latestand abovesteps:. To keep functionality unchanged but explicit, setcontents: read, which is sufficient for most actions that might need to read basic repository metadata yet prevents unintended write operations. No imports or additional methods are needed; this is purely a YAML configuration change within the existing workflow.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crazy work, github bot