Skip to content

UI feature fixes #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louisch wants to merge 3 commits into
base: master
Choose a base branch
from
Open

UI feature fixes #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9d05f8a
Add graph with metadata to test dataset
louisch Apr 1, 2026
5a6429c
Add test that overview can be scrolled when overflowing
louisch Apr 1, 2026
173fbde
Change test to check tooltip is entirely inside viewport
louisch Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions test_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ def random_created_at():
return int(created.timestamp() * 1000)


def setup_graph_with_metadata(graph):
setup_graph(graph)
for i in range(0, 20):
graph.add_metadata({ f"prop{i}": 100 })
return graph


def setup_large_graph(graph):
graph.add_node(0, "center")
for i in range(0, 500):
Expand Down Expand Up @@ -193,6 +200,9 @@ def __main__():
graph.save_to_file(f"{work_dir}/new_folder/persistent_second_filler")
graph.save_to_file(f"{work_dir}/vanilla/persistent_second_filler")

graph = setup_graph_with_metadata(Graph())
graph.save_to_file(f"{work_dir}/vanilla/graph_with_metadata")

server = graphql.GraphServer(work_dir=work_dir)
server.run(port=port)

Expand Down
11 changes: 11 additions & 0 deletions tests/e2e/graph.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,17 @@ test('Click on Ben node in graph', async ({ page }) => {
await expect(page.getByText('Age', { exact: true })).toBeVisible();
});

test('Overflowing elements can be scrolled into view', async ({ page }) => {
await navigateToSavedGraphBySavedGraphsTable(
page,
'vanilla',
'graph_with_metadata',
);
await expect(page.getByText('Relationships')).not.toBeInViewport();
await page.getByText('Relationships').scrollIntoViewIfNeeded();
await expect(page.getByText('Relationships')).toBeInViewport();
});

test('Double click expand node and delete by floating actions button', async ({
page,
}) => {
Expand Down
6 changes: 4 additions & 2 deletions tests/e2e/temporalview.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ async function hoverEdgeAndExpectTooltip(
const box = await line.boundingBox();
if (!box) throw new Error(`Element ${selector} is not visible or rendered`);
await page.mouse.move(box.x + box.width / 2, box.y + box.height / 2);
await expect(page.getByText(expectedText)).toBeVisible();
await expect(page.getByText(expectedText)).toBeInViewport({ ratio: 1 });
await page.mouse.move(0, 0);
}

Expand All @@ -48,7 +48,9 @@ test('Close temporal view button and open again', async ({ page }) => {
await expect(page.locator('text="Ben"')).toBeVisible();
});

test('Temporal view hover over edges', async ({ page }) => {
test('Temporal view hover over edges and ensure tooltips in viewport', async ({
page,
}) => {
await setupGraphPage(page);

await hoverEdgeAndExpectTooltip(
Expand Down