Optimize select() statements by removing redundant conditions#7252
Closed
Optimize select() statements by removing redundant conditions#7252
Conversation
When using np.select(), the most efficient pattern is to have the default handle the most common case(s), eliminating explicit condition checks. This commit: - Removes explicit conditions that return the same value as the default - Adds clarifying comments documenting what cases the default covers - Reduces condition evaluations from N to N-k where k conditions matched default Key optimizations: - taxsim_mstat: SINGLE and HOH both return 1, now handled by default - age_group: WORKING_AGE (most common) now handled by default - 70+ state tax files: SINGLE filing status now handled by default Performance benefit: Each removed condition eliminates one array comparison per element during vectorized calculations. 74 files changed, net -10 lines of code. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimizes all
np.select()statements in the codebase by removing conditions that return the same value as the default. This is the numpy-efficient pattern where the default handles the most common case(s).Key insight: When using
np.select(), each condition requires an array comparison. By settingdefault=to the most common value and removing explicit conditions for that value, we reduce evaluations from N to N-k.Example optimization (taxsim_mstat.py)
Before:
After:
Changes
Performance benefit
Each removed condition eliminates one boolean array comparison per element. For microsimulations with millions of tax units, this reduces memory allocations and CPU cycles.
Test plan
Supersedes #7242 (which only added
default=without removing redundant conditions)🤖 Generated with Claude Code