Backdating Washington TANF

[hua7450]

Summary

Fixes #7199

Adds historical parameter values to Washington TANF, extending data back to 2016 based on Washington State Register (WSR) filings.

Changes

Parameters Updated

Parameter	Historical Values Added
payment_standard/amount.yaml	2016-02-01, 2018-07-01, 2021-07-01
income/limit.yaml	2016-02-01, 2018-07-01, 2021-07-01, split 2024 into 2024-01-01 and 2024-08-01
resource_limit.yaml	1998-09-01 ($1,000), fixed dates: 2019-02-01 ($6,000), 2024-02-01 ($12,000)
maximum_family_size.yaml	2016-01-01
earned_income_disregard/rate.yaml	1998-09-01 (renamed from percentage_disregarded.yaml)
earned_income_disregard/amount.yaml	Fixed date to 2024-08-01
earned_income_disregard/in_effect.yaml	New file - boolean to track when $500 flat disregard applies

Parameters Deleted

• payment_standard/maximum_amount.yaml - Redundant with maximum_family_size capping payment standard at size 10

Variables Updated

• wa_tanf.py - Removed maximum_amount cap (handled by maximum_family_size)
• wa_tanf_countable_earned_income.py - Updated to use in_effect and rate parameters

Tests Updated

• Added historical tests for 2018-01 period verifying 2016 parameter values
• Added historical tests for 2022-01 period verifying 2021-07-01 parameter values (15% increase)
• Fixed tests to use correct periods (2025-01 for Aug 2024+ rules, 2024-01 for pre-Aug rules)
• Removed references to deleted maximum grant cap

Regulatory Sources

• WAC 388-478-0020 - Payment standards
• WAC 388-478-0035 - Income limits
• WAC 388-470-0005 - Resource limits
• WAC 388-450-0170 - Earned income deductions
• WSR 16-01-093 - 2016 values
• WSR 18-09-088 - 2018 values
• WSR 21-21-054 - 2021 values (15% increase effective July 1, 2021)
• WSR 23-23-054 - 2024 values
• E2SHB 1831 - Resource limit increase to $6,000 (2019)
• HB 1447 - $500 flat disregard and $12,000 resource limit (2024)

Test Plan

• All 83 WA TANF tests pass
• Historical tests verify 2018-01 uses 2016 parameter values
• Historical tests verify 2022-01 uses 2021-07-01 parameter values (15% increase)
• Tests verify correct behavior before and after Aug 2024 policy changes

🤖 Generated with Claude Code

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (60c5dcc) to head (2763d1a).
⚠️ Report is 25 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##             main     #7202       +/-   ##
============================================
+ Coverage   73.76%   100.00%   +26.23%     
============================================
  Files        3666         3     -3663     
  Lines       52712        43    -52669     
  Branches      263         0      -263     
============================================
- Hits        38882        43    -38839     
+ Misses      13815         0    -13815     
+ Partials       15         0       -15     

Flag	Coverage Δ
unittests	100.00% <100.00%> (+26.23%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[PavelMakarchuk]

PR Review - Washington TANF Backdating

🔴 Critical Issues (Must Fix Before Merge)

None identified. All historical values verified against WSR filings.

---

🟡 Should Address

1. Missing 2022-01 Period Tests

Several test files lack coverage for the 2022-01 period (uses July 2021 values):

• wa_tanf_resources_eligible.yaml - No 2022-01 tests (should show $6,000 limit)
• wa_tanf_countable_earned_income.yaml - No 2022-01 tests (50% disregard only)
• wa_tanf.yaml - No 2022-01 or 2025-01 period tests

2. Missing 2025-01 Period Tests

• wa_tanf_payment_standard.yaml - No 2025-01 tests to verify Jan 2024 values still apply

3. Missing Reference for 2024 Payment Standards

File: payment_standard/amount.yaml

• WSR 23-23-054 corroborates the 2024-01-01 values but is not in the reference list (only in income/limit.yaml)
• Fix: Add WSR 23-23-054 to payment_standard references

4. Missing Reference for Historical $1,000 Resource Limit

File: resource_limit.yaml

• The 1998-09-01 $1,000 value is explained in a comment but lacks a direct reference link

5. Minor Date Discrepancy for 2016 Values

• WSR 16-01-093 states effective date as January 15, 2016
• PR uses 2016-02-01 (16 days later)
• Suggestion: Consider using 2016-01-01 for consistency with first-of-month convention

---

🟢 Suggestions

1. Comment update needed: wa_tanf_eligible.py:28 mentions "$6,000" resource limit but current value is $12,000 for 2024+

2. Boundary tests: Add one-dollar-below threshold tests for resource limits ($11,999, $5,999)

3. Zero resource tests: Add tests verifying zero resources pass eligibility

---

✅ What's Verified Correct

Parameter	Historical Values	Status
Payment Standard	2016, 2018, 2021, 2024	✓ All verified against WSR filings
Income Limit	2016, 2018, 2021, 2024-01, 2024-08	✓ All verified
Resource Limit	1998→$1K, 2019→$6K, 2024→$12K	✓ Verified against legislation
Earned Income Disregard	50% rate, $500 flat (Aug 2024)	✓ Verified against WAC 388-450-0170
in_effect parameter	Boolean for $500 disregard	✓ Correctly false before Aug 2024

Key Policy Timeline Verified:

• 2016: 9% increase in payment standards
• 2018: 9.3% increase
• 2021: 15% increase (WSR 21-21-054)
• 2024-01: 8% increase
• 2024-08: $500 flat disregard added, income limits raised by $500

---

Validation Summary

Check	Result
Historical Values	✅ All WSR values verified
Effective Dates	⚠️ Minor 2016 date discrepancy
Reference Quality	⚠️ Missing 2024 WSR in payment_standard
Code Patterns	✅ All patterns correct
Test Coverage	⚠️ Missing 2022-01 and 2025-01 tests
CI Status	✅ All 83 tests passing

---

Code Changes Verified

Change	Status
Removed maximum_amount.yaml	✓ Safe - no code references it
wa_tanf_countable_earned_income.py uses in_effect	✓ Correct where() pattern
wa_tanf.py removed max cap	✓ Handled by maximum_family_size

---

Test Coverage: 83 Tests Passing

File	Tests
integration.yaml	21
wa_tanf_income_eligible.yaml	15
wa_tanf_countable_earned_income.yaml	12
wa_tanf_payment_standard.yaml	12
wa_tanf.yaml	11
wa_tanf_eligible.yaml	6
wa_tanf_resources_eligible.yaml	6

---

Historical Value Verification

Payment Standard Size 1:

Period	PR Value	WSR Value	Match
2016-02-01	$332	$332	✓
2018-07-01	$363	$363	✓
2021-07-01	$417	$417	✓
2024-01-01	$450	$450	✓

Income Limit Relationship Verified:

• Jan 2024: Limit = 2 × Payment Standard (exact for all sizes)
• Aug 2024: Limit = Jan 2024 + $500 (exact for all sizes)

---

Next Steps

To auto-fix issues: /fix-pr 7202

Or address manually:

1. Add 2022-01 tests to wa_tanf_resources_eligible.yaml and wa_tanf_countable_earned_income.yaml
2. Add 2025-01 tests to wa_tanf.yaml and wa_tanf_payment_standard.yaml
3. Add WSR 23-23-054 reference to payment_standard/amount.yaml

---

🤖 Generated with Claude Code - Complete Review Plugin

[PavelMakarchuk]

Not sure if I am right, but can we add an integration test or two for 2018 for all backdating PRs?

[PavelMakarchuk]

It will not work with this parameter being backdated right?

[hua7450]

This $500 disregard is a new feature start effect in 2024-08. So if 2024-07, no 500 disregard, to test it output, compare test cases of 2024-01 and 2025-01

[hua7450]

Not sure if I am right, but can we add an integration test or two for 2018 for all backdating PRs?

I have test cases in wa_tanf_countable_earned_income.yaml‎