Write Stage 5 release promotion contract#1039
Merged
Merged
Conversation
3c424fe to
77458c0
Compare
Base automatically changed from
agent/stage-5/pr-5-3-typed-promotion-results
to
main
May 22, 2026 13:23
e76a4b9 to
cdab9c2
Compare
cdab9c2 to
3bb4445
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Summary
ReleasePromotionContractBuilderand helpers for Stage 5release_promotion_contract.json.promote_runafter the full promotion transaction succeeds and record it as a Stage 5 manifest output.policyengine-usto1.703.2.Validation
ruff check modal_app/pipeline.py policyengine_us_data/release_promotion/__init__.py policyengine_us_data/release_promotion/contract.py policyengine_us_data/release_promotion/results/__init__.py policyengine_us_data/release_promotion/results/full.py tests/unit/release_promotion/test_contract.py tests/unit/release_promotion/test_results.py tests/unit/test_pipeline.py tests/unit/test_pipeline_source_contracts.pyruff format --check modal_app/pipeline.py policyengine_us_data/release_promotion/__init__.py policyengine_us_data/release_promotion/contract.py policyengine_us_data/release_promotion/results/__init__.py policyengine_us_data/release_promotion/results/full.py tests/unit/release_promotion/test_contract.py tests/unit/release_promotion/test_results.py tests/unit/test_pipeline.py tests/unit/test_pipeline_source_contracts.pyuv run --no-sync pytest tests/unit/release_promotion/test_contract.py tests/unit/release_promotion/test_results.py tests/unit/test_pipeline_source_contracts.py tests/unit/test_pipeline_docs_extractor.py tests/unit/test_pipeline_doc_guards.py(40 passed)uv run --no-sync python .github/scripts/check_policyengine_us_dependency.py --mode failuv lock --checkuv run --no-sync --with pyyaml python scripts/extract_pipeline_docs.pygit diff --check origin/main...HEADNote:
tests/unit/test_pipeline.pyremains Modal-gated locally; withoutmodalinstalled, pytest collects0 items / 1 skippedand exits with code 5. The subprocess-result parser is covered through the non-Modal Stage 5 result tests plus a source-contract test that ensures the Modal helper delegates to the pure parser.