Alberta Caregiver Amount by Kenyaokun · Pull Request #332 · PolicyEngine/policyengine-canada

Kenyaokun · 2023-06-08T22:12:54Z

First try #331

Co-authored-by: YiweiJ YiweiJ@users.noreply.github.com

First try PolicyEngine#331 Co-authored-by: YiweiJ <YiweiJ@users.noreply.github.com>

Final Draft PolicyEngine#331 Co-authored-by: YiweiJ <YiweiJ@users.noreply.github.com> Co-authored-by: 7qiwx <7qiwx@users.noreply.github.com>

…-canada into Kenyaokun/issue331

Done PolicyEngine#331

Kenyaokun · 2023-07-04T18:06:07Z

I actually run several times make format, but the Lint would not pass, not sure why it does not work @MaxGhenis @PavelMakarchuk

MaxGhenis · 2023-07-04T18:08:08Z

Try pip install -U black?

Update PolicyEngine#331

Kenyaokun · 2023-07-04T18:13:53Z

Cool, it works!

...ers/gov/provinces/ab/tax/income/credits/credits_return/lower_dependant_income_threshold.yaml

...ada/parameters/gov/provinces/ab/tax/income/credits/credits_return/lower_age_eligibility.yaml

...ers/gov/provinces/ab/tax/income/credits/credits_return/lower_dependant_income_threshold.yaml

PavelMakarchuk · 2023-07-25T09:09:08Z

policyengine_canada/variables/gov/provinces/ab/tax/credits_return/ab_caregiver_amount.py

+            dependant_net_income <= p.upper_dependant_income_threshold
+        )
+
+        caregiver_amount = (


dont we need the amount for the eligible dependent as well?

I think we don't need the amount for the eligible dependants: https://www.canada.ca/en/revenue-agency/services/forms-publications/tax-packages-years/general-income-tax-benefit-package/alberta/5009-pc/information-residents-alberta.html The website mentioend that "If you and another person support the same dependant, you can split the claim for that dependant. However, the total amount of your claim and the other person's claim cannot be more than the maximum amount allowed for that dependant." I think why we should include the maxmium amount.

policyengine_canada/variables/household/person/is_parent_or_grandparent.py

…-canada into Kenyaokun/issue331

Fixes PolicyEngine#331

PavelMakarchuk · 2023-10-10T23:12:32Z

changelog_entry.yaml

+- bump: minor
+  changes:
+    added:
+    - Alberta Caregiver Amount.


Suggested change

- Alberta Caregiver Amount.

- Alberta caregiver amount.

PavelMakarchuk · 2023-10-10T23:12:40Z

...ne_canada/parameters/gov/provinces/ab/tax/income/credits/credits_return/age_eligibility.yaml

@@ -0,0 +1,11 @@
+description: Alberta limits its Child and Family Benefit to people above this age.
+values:
+  2023-01-01: 18


find 2022 values

all yaml files

PavelMakarchuk · 2023-10-10T23:12:53Z

...ne_canada/parameters/gov/provinces/ab/tax/income/credits/credits_return/age_eligibility.yaml

+  label: Alberta child and Family Benefit adult dependant age eligibility
+  reference:
+  - title: Province of Alberta - Alberta Child and Family Benefit
+    href: https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/td1ab/td1ab-23e.pdf


add pdf pages

all yaml files

PavelMakarchuk · 2023-10-10T23:13:42Z

policyengine_canada/variables/gov/provinces/ab/tax/credits_return/live_together.py

+class live_together(Variable):
+    value_type = bool
+    entity = Person
+    label = "Albert Caregiver Dependant"


Suggested change

label = "Albert Caregiver Dependant"

label = "Dependant living with the head of household"

PavelMakarchuk · 2023-10-10T23:13:50Z

policyengine_canada/variables/gov/provinces/ab/tax/credits_return/live_together.py

+from policyengine_canada.model_api import *
+
+
+class live_together(Variable):


Suggested change

class live_together(Variable):

class cohabitating_dependant(Variable):

PavelMakarchuk · 2023-10-10T23:14:01Z

policyengine_canada/variables/gov/provinces/ab/tax/credits_return/live_together.py

+    documentation = "Whthere your spouse's or common-law partner's dependant lives with you or not."
+    definition_period = YEAR
+    reference = "chrome-extension://efaidnbmnnnibpcajpcglclefindmkaj/https://www.canada.ca/content/dam/cra-arc/formspubs/pbg/td1ab/td1ab-23e.pdf"
+    defined_for = ProvinceCode.AB


Suggested change

defined_for = ProvinceCode.AB

PavelMakarchuk · 2023-10-10T23:14:15Z

policyengine_canada/variables/gov/provinces/ab/tax/credits_return/live_together.py

move this to the household folder

PavelMakarchuk · 2024-05-15T00:20:56Z

Duplicate of #487

Kenyaokun and others added 5 commits June 8, 2023 22:12

Alberta Caregiver Amount

10e6588

First try PolicyEngine#331 Co-authored-by: YiweiJ <YiweiJ@users.noreply.github.com>

Alberta Caregiver Amount

d8b6879

Debug PolicyEngine#331

Alberta Caregiver Amount

fdd9a60

Final Draft PolicyEngine#331 Co-authored-by: YiweiJ <YiweiJ@users.noreply.github.com> Co-authored-by: 7qiwx <7qiwx@users.noreply.github.com>

Merge branch 'master' of https://github.com/PolicyEngine/policyengine…

ee7dc1f

…-canada into Kenyaokun/issue331

Alberta Caregiver Amount

74dbb83

Done PolicyEngine#331

Alberta Caregiver Amount

3f6d0d8

Update PolicyEngine#331

Kenyaokun marked this pull request as ready for review July 4, 2023 18:19

PavelMakarchuk reviewed Jul 25, 2023

View reviewed changes

...ers/gov/provinces/ab/tax/income/credits/credits_return/lower_dependant_income_threshold.yaml Outdated Show resolved Hide resolved

PavelMakarchuk reviewed Jul 25, 2023

View reviewed changes

...ada/parameters/gov/provinces/ab/tax/income/credits/credits_return/lower_age_eligibility.yaml Show resolved Hide resolved

PavelMakarchuk reviewed Jul 25, 2023

View reviewed changes

...ers/gov/provinces/ab/tax/income/credits/credits_return/lower_dependant_income_threshold.yaml Outdated Show resolved Hide resolved

PavelMakarchuk reviewed Jul 25, 2023

View reviewed changes

policyengine_canada/variables/household/person/is_parent_or_grandparent.py Outdated Show resolved Hide resolved

Kenyaokun added 2 commits July 25, 2023 23:13

Merge branch 'master' of https://github.com/PolicyEngine/policyengine…

dc870ec

…-canada into Kenyaokun/issue331

Alberta Caregiver Amount

9e990a7

Fixes PolicyEngine#331

Kenyaokun requested a review from PavelMakarchuk October 10, 2023 21:43

PavelMakarchuk reviewed Oct 10, 2023

View reviewed changes

policyengine_canada/variables/gov/provinces/ab/tax/credits_return/live_together.py

Copy link

Collaborator

PavelMakarchuk Oct 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to the household folder

SirMalamute mentioned this pull request Apr 29, 2024

Alberta Caregiver Amount #487

Draft

PavelMakarchuk marked this as a duplicate of #487 May 15, 2024

PavelMakarchuk closed this May 15, 2024

	label = "Albert Caregiver Dependant"
	label = "Dependant living with the head of household"

		from policyengine_canada.model_api import *


		class live_together(Variable):

	class live_together(Variable):
	class cohabitating_dependant(Variable):

Conversation

Kenyaokun commented Jun 8, 2023

Uh oh!

Kenyaokun commented Jul 4, 2023

Uh oh!

MaxGhenis commented Jul 4, 2023

Uh oh!

Kenyaokun commented Jul 4, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kenyaokun Jul 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PavelMakarchuk commented May 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Kenyaokun Jul 25, 2023 •

edited

Loading