Skip to content

Remove ReviewDog and add lint directives to CLAUDE.md #593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
maxachis wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Remove ReviewDog and add lint directives to CLAUDE.md #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/python_checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,5 @@ jobs:
with:
python-version: "3.11"
- run: pip install flake8 flake8-docstrings flake8-simplify flake8-unused-arguments flake8-annotations
- name: flake8 Lint with Reviewdog
uses: reviewdog/action-flake8@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
flake8_args: --ignore E501,W291,W293,D401,D400,E402,E302,D200,D202,D205,W503,E203,D204,D403
level: warning
- name: Run flake8
run: flake8 . --ignore E501,W291,W293,D401,D400,E402,E302,D200,D202,D205,W503,E203,D204,D403
4 changes: 4 additions & 0 deletions CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,10 @@ See `ENV.md` for the full reference. Key categories:

## Important Notes

- Follow the repository's linting style guide when writing or editing Python:
- Run `flake8` with this exact ignore set in mind: `E501,W291,W293,D401,D400,E402,E302,D200,D202,D205,W503,E203,D204,D403`
- Keep import ordering and blank-line usage compliant with `flake8` defaults aside from the ignore list above
- Prefer concise docstrings where present and avoid introducing new docstring violations outside ignored codes
- The app exposes its API docs at `/api` (not the default `/docs` — `/docs` redirects to `/api`).
- CORS is configured for `localhost:8888`, `pdap.io`, and `pdap.dev`.
- Two permission levels: `access_source_collector` (general) and `source_collector_final_review` (final review).
Expand Down
Loading