Skip to content

insert urls bug #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxachis merged 1 commit into from
Jul 31, 2025
Merged

insert urls bug #354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/db/client/async_.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -901,6 +901,7 @@ async def insert_url(self, session: AsyncSession, url_info: URLInfo) -> int:
batch_id=url_info.batch_id,
url_id=url_entry.id
)
session.add(link)
return url_entry.id

@session_manager
Expand Down
10 changes: 10 additions & 0 deletions tests/automated/integration/db/client/test_insert_urls.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

from src.core.enums import BatchStatus
from src.db.models.instantiations.batch.pydantic import BatchInfo
from src.db.models.instantiations.link.batch_url import LinkBatchURL
from src.db.models.instantiations.url.core.pydantic import URLInfo
from src.db.models.instantiations.url.core.sqlalchemy import URL


@pytest.mark.asyncio
Expand Down Expand Up @@ -46,3 +48,11 @@ async def test_insert_urls(

assert insert_urls_info.original_count == 2
assert insert_urls_info.duplicate_count == 1

urls = await adb_client_test.get_all(URL)
assert len(urls) == 2

links: list[LinkBatchURL] = await adb_client_test.get_all(LinkBatchURL)
assert len(links) == 2
for link in links:
assert link.batch_id == batch_id