Skip to content

Fix bug where DS approved URLs converted to SC validated #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxachis merged 1 commit into from
Jul 26, 2025
Merged

Fix bug where DS approved URLs converted to SC validated #345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/tasks/scheduled/sync/data_sources/queries/upsert/helpers/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def convert_to_source_collector_url_status(

match ds_approval_status:
case ApprovalStatus.APPROVED:
return URLStatus.VALIDATED
return URLStatus.SUBMITTED
case ApprovalStatus.REJECTED:
return URLStatus.NOT_RELEVANT
case ApprovalStatus.NEEDS_IDENTIFICATION:
Expand Down
4 changes: 2 additions & 2 deletions tests/automated/integration/tasks/scheduled/sync/data_sources/setup/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
url_status=URLStatus.PENDING,
agencies_assigned=[AgencyAssigned.ONE, AgencyAssigned.THREE]
),
final_url_status=URLStatus.VALIDATED
final_url_status=URLStatus.SUBMITTED
),
TestURLSetupEntry(
# A DS-only approved but broken URL
Expand Down Expand Up @@ -94,7 +94,7 @@
url_status=URLStatus.PENDING,
agencies_assigned=[]
),
final_url_status=URLStatus.VALIDATED
final_url_status=URLStatus.SUBMITTED
)
]