-
Notifications
You must be signed in to change notification settings - Fork 7
Dev #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…_filter_by_batch_id feat(app): Add batch filtering for annotation requests
Additionally, modify `review/approve-source` to no longer accept `relevant` key-value pair.
…_review_reject_source feat(app): add `review/reject-source` endpoint
Now, URLs marked not relevant by a user should not show up for subsequent annotations such as record type or agency.
…_hide_user_not_relevant feat(database): Adjust annotation logic for URLs marked not relevant
Previously, the `/annotate/agencies` `POST` method would return a 500 error when an agency whose ID was not yet in the DBI database was submitted. This has been resolved.
…_add_agency_ids_via_annotate_agencies feat(database): add agency not in database in annotate agencies
BREAKING CHANGE: All `/review/`endpoints now require the `source_collector_final_review` permission
# Conflicts: # core/AsyncCore.py
…ate_misc_metadata_task_html Mc update misc metadata task html
…_annotation_without_html_info feat(app): allow retrieving URLs for annotation without html info
The task loop has been modified such that, if prerequisites continue to be met, the same task loop will run again. In the case of the task looping more than 20 times, the task loop is set to break and discord notified as an indicator of potentially unwelcome activity.
…_agencies_sync mc_315_agencies_sync
# Conflicts: # api/main.py
link to api tos
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 16713553 | Triggered | Generic Password | 72ed9c9 | local_database/setup_fdw.sh | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…mocked_url_request_interface Add logic for storing compressed html when scraping HTML
for accuracy!
…_html_and_inference mc_329_html_and_inference
- Inconsistency between prereq check and dto for relevancy task - Incorrect DTO used for relevancy annotation get endpoint
- Inconsistency between prereq check and dto for relevancy task - Incorrect DTO used for relevancy annotation get endpoint
…_html_and_inference Fix broken logic in SC app
…separate_batches_from_urls Mc 89 separate batches from urls
Updating Main from Dev. Dev is currently what gets deployed, and we want to fix that!