Skip to content

Revert "Added Follow-Me to Squirtle, Pichu, Magmar" #1415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
programgames wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Revert "Added Follow-Me to Squirtle, Pichu, Magmar" #1415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions data/v2/csv/pokemon_moves.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7137,7 +7137,6 @@ pokemon_id,version_group_id,move_id,pokemon_move_method_id,level,order,mastery
7,6,290,4,0,,
7,6,291,4,0,,
7,6,352,4,0,,
7,7,266,1,0,,
7,7,33,1,1,,
7,7,39,1,4,,
7,7,145,1,7,,
Expand Down Expand Up @@ -133036,7 +133035,6 @@ pokemon_id,version_group_id,move_id,pokemon_move_method_id,level,order,mastery
126,12,249,4,0,,
126,12,263,4,0,,
126,12,264,4,0,,
126,12,266,4,0,,
Copy link
Member

@Naramsim Naramsim Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! This is Magmar (126). It seems that Magmar learns Follow Me in Gen3, game Colosseum, After Purifying in XD. So the move is correct, the method used to learn it is wrong, it shouldn't be 4 but 9.

Did you disclose you used AI in your submission? I see Claude commited to this PR.

@phalt

Copy link

@notblisy notblisy Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll correct and say that Magmar learns follow me in XD, which is different from Colosseum. I've submitted a PR here with every XD purification move. I also wouldn't keep the game as FRLG, it should be for XD.

There's also been some discussion on if these moves should even be modeled in here

Copy link
Member

@phalt phalt Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed the co-author there, and followed the bulbapedia links to verify.

There was no disclosure here, so we may have to close the PR.

Copy link
Member

@Naramsim Naramsim Feb 18, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll correct and say that Magmar learns follow me in XD, which is different from Colosseum. I've submitted a PR here with every XD purification move. I also wouldn't keep the game as FRLG, it should be for XD.

There's also been some discussion on if these moves should even be modeled in here

Hi I didn't check PR 1410 yet. Are you adding Follow Me for Magmar there? Should we address that beforehand?

Copy link
Contributor

@linnos linnos Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello I made the original commit and this is where I got the information:
https://bulbapedia.bulbagarden.net/wiki/Follow_Me_(move)
According to this page

Squirtle: Gen 5 from Sticker promotional Egg Squirtle and Kanto First Partner Egg Squirtle
Pichu: Gen 3 PokePark Eggs
Magmar: Gen 3 Purified Shadow Pokemon. Also learned by pre-evolution Magby by breeding.

Copy link

@notblisy notblisy Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll correct and say that Magmar learns follow me in XD, which is different from Colosseum. I've submitted a PR here with every XD purification move. I also wouldn't keep the game as FRLG, it should be for XD.
There's also been some discussion on if these moves should even be modeled in here

Hi I didn't check PR 1410 yet. Are you adding Follow Me for Magmar there? Should we address that beforehand?

Yes, I am adding Follow Me Magmar there. All 83 Shadow Pokemon come with some special moves and that commit intends to add everything. I would address that before adding Magmar independently here.

Hello I made the original commit and this is where I got the information: https://bulbapedia.bulbagarden.net/wiki/Follow_Me_(move) According to this page

Squirtle: Gen 5 from Sticker promotional Egg Squirtle and Kanto First Partner Egg Squirtle Pichu: Gen 3 PokePark Eggs Magmar: Gen 3 Purified Shadow Pokemon. Also learned by pre-evolution Magby by breeding.

Magby does not learn the egg move by breeding until Scarlet/Violet. XD is the only way Magmar learned Follow Me until SV readded that move to its learnset. According to the bulbapedia article you linked, no pokemon at all even had follow me as an egg move until gen 4.

It also doesn't look like the API right now supports events in any way. It'd probably need to be a new acquisition method.

126,12,280,4,0,,
126,12,290,4,0,,
126,13,7,1,1,4,
Expand Down Expand Up @@ -180538,7 +180536,6 @@ pokemon_id,version_group_id,move_id,pokemon_move_method_id,level,order,mastery
172,7,237,4,0,,
172,7,240,4,0,,
172,7,263,4,0,,
172,7,266,4,0,,
172,7,290,4,0,,
172,7,351,4,0,,
172,8,84,1,1,1,
Expand Down