Add XD Purification moves to pokemon_moves.csv#1410
Open
notblisy wants to merge 2 commits intoPokeAPI:masterfrom
Open
Add XD Purification moves to pokemon_moves.csv#1410notblisy wants to merge 2 commits intoPokeAPI:masterfrom
notblisy wants to merge 2 commits intoPokeAPI:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Issue 1408]
None of the moves learned from XD Purification are in pokemon_moves.csv, despite this having an ID in pokemon_move_methods.csv (9, XD-Purification) as noted in this issue.
When a Pokemon is Purified in XD, it gain 4 Attacks. One is completely unique to XD, and the others are usually a mix of egg moves, tms, and level up moves.
For example, Salamence will know:
Refresh(XD Exclusive), Dragon Claw (Tm & Level up), Aerial Ace (TM), and Dragon Dance (Egg Move).
Originally I was going to only include the XD Exclusive moves in this pull request, but decided to do all 4 moves for a few reasons.
Double ups are common, plenty of Pokemon learn moves via TM & Level up, for example. (Salamence learns both dragon claw through level up and as a TM, aside from XD)
It has legality implications. For example, if refresh was the only move listed as a purification move, a person may think that Dragon Dance + Refresh is not a legal combination to have on Salamence, since Dragon Dance usually comes from breeding, and the salamence from XD is captured, not bred.
TMs are a finite resource in the Gen 3 games, so it can be helpful to know which Pokemon you can catch that would have a TM move learned already.
I've inserted all the move lists (it's 4 moves each, per pokemon) after their XD tutor move listings in the following format into pokemon_moves.csv using salamence as an example:
pokemon_id,version_group_id,move_id,pokemon_move_method_id,level,order,mastery
373,13,337,9,0,,
373,13,287,9,0,,
373,13,349,9,0,,
373,13,332,9,0,,
I left level as 0 because while a shadow Pokemon are caught at a static level in XD, on purification, they gain EXP based on how much you used the Pokemon.
So you could purify a teddiursa without sending into battle once and have it be level 11, the level it was captured, or purify it after using in a ton of battles and it'll gain the EXP it would have gained as a regular Pokemon.
order and mastery are not relevant. You learn all 4 moves at once and mastery is for PLA.
Thanks!