Open
Conversation
Member
|
Hello, you have to fix the formatting, according to clang-format. Also, give this PR a more meaningful title. Otherwise I would have to assume that this is just a spam pull request. |
Author
|
ok thank |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
move
Replaced manual Vector3d initialization (v << vx, vy, vz;) with direct constructor:
const Vector3d v(vx, vy, vz);
Avoided repeated calls to pose_.translation() by storing it in a const reference:
const Vector3d& t = pose_.translation();
Used that reference to assign x_, y_, z_.
updatePose
Declared rotation matrix m as const and initialized it directly instead of default-construct + assign.
Replaced:
pose_ *= m;
with:
pose_.linear() = m;
(more explicit and avoids unnecessary transform multiplication)
Replaced manual vector construction:
Vector3d v;
v << x_, y_, z_;
pose_.translation() = v;
with:
pose_.translation() = Vector3d(x_, y_, z_);
setParameters
Added const to local helper variables.
Precomputed:
const float inv_width;
const float inv_height;
instead of dividing by width_ and height_ multiple times.
Minor formatting alignment for readability.
Changed z_nf to const.