Adding b-spline single-crease patch basis#844
Open
manuelk wants to merge 2 commits intoPixarAnimationStudios:devfrom
Open
Adding b-spline single-crease patch basis#844manuelk wants to merge 2 commits intoPixarAnimationStudios:devfrom
manuelk wants to merge 2 commits intoPixarAnimationStudios:devfrom
Conversation
- add math.h for floorf & exp2f functions
Contributor
|
Thanks Manuel! those changes look great. |
Author
|
No worries : just putting trying to pave the way forward. I am on hold until Barry pushes his refactors to patch tables, since i will want to integrate those into the characteristic map factories. |
Collaborator
|
Manuel, the major work planned to the PatchTables (at least for this release) should now be in place. There will be some minor changes coming from David and myself to improve and enable the new features (face-varying and inf-sharp patches), but nothing major. |
|
Filed as internal issue #151987. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a basis for CPU evaluation of single-crease patches (b-splines). Do we need Bezier too ?