Merged
Conversation
…le ORM project - Deleted CYCLE_ORM_UPDATE_STATUS.md as it is no longer relevant. - Removed PACKAGIST_MIGRATION_REPORT.md which is obsolete after migration. - Eliminated PHPSTAN_FIXES_SUMMARY.md as fixes are now integrated. - Removed composer.json.local and composer.json.production files as they are no longer needed. - Deleted composer.scripts.json since its content is now part of composer.json. - Removed examples of usage patterns in valida-conceito-patterns.md as they are outdated. - Deleted metodos-corretos-helixphp.md for being redundant. - Removed update_composer_for_production.sh and update_dependencies.sh scripts as they are no longer necessary.
…a composer.json para versão específica do pivotphp/core; modifica phpunit.xml para desativar falhas em depreciações e altera MetricsCollector para logar falhas de consulta apenas fora do ambiente de teste
…mprove logging condition
…llector e atualiza a lógica de registro de falhas de consulta
…ma e melhora o cache nas verificações de ambiente
…e do EnvironmentHelper e melhora o gerenciamento de cache
There was a problem hiding this comment.
Pull Request Overview
This PR aligns the package with the new pivotphp/core release by removing legacy scripts, introducing cross-platform test coverage tooling, caching environment checks, and updating Composer and PHPUnit configurations.
- Removed deprecated dependency‐management and environment‐switcher scripts
- Added centralized caching in
EnvironmentHelperand conditional logging inMetricsCollector - Introduced cross-platform coverage scripts and updated
phpunit.xmlandcomposer.jsonaccordingly
Reviewed Changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| update_dependencies.sh | Deleted legacy dependency‐update script |
| update_composer_for_production.sh | Deleted production composer‐update script |
| src/Monitoring/MetricsCollector.php | Conditional error logging based on testing environment |
| src/Helpers/EnvironmentHelper.php | Added static cache, enhanced env detection, and clearCache() |
| scripts/test-coverage.* | Added cross-platform test coverage scripts (sh, ps1, php, bat) |
| phpunit.xml | Enabled failOnDeprecation, replaced <coverage> with <source> |
| composer.json | Bumped pivotphp/core to ^1.1.0, pointed test-coverage to script |
| README.md | Documented cross-platform coverage commands |
Comments suppressed due to low confidence (2)
phpunit.xml:34
- The
<coverage>section with report configuration was removed in favor of<source>. Ensure PHPUnit 10 is configured (for example via<logging>) to still generate HTML and Clover reports as expected.
<source>
src/Monitoring/MetricsCollector.php:5
- The import for EnvironmentHelper assumes it resides in the PivotPHP\CycleORM\Helpers namespace, but the class file itself does not declare that namespace. Please add the correct namespace to EnvironmentHelper or adjust the import path.
use PivotPHP\CycleORM\Helpers\EnvironmentHelper;
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.