Skip to content

Conversation

@bjsowa
Copy link

@bjsowa bjsowa commented Jan 5, 2026

The generate_parameter_module macro outputs the Python module to CMAKE_INSTALL_DIR during the build phase. This results in build failures on the ROS buildfarm due to permission errors (example here)

This PR modifies the macro to output the module to a temporary directory in CMAKE_CURRENT_BINARY_DIR and install it to CMAKE_INSTALL_DIR during the install phase.

@christophfroehlich
Copy link
Collaborator

If the current setup fails on the buildfarm, why haven't that failed earlier? Or is it that simple, nobody released a python node using this library?

@bjsowa
Copy link
Author

bjsowa commented Jan 6, 2026

If the current setup fails on the buildfarm, why haven't that failed earlier? Or is it that simple, nobody released a python node using this library?

From what I see, we are the first 😎

Copy link
Collaborator

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The result looks good, just not sure if there is a more cmake-native way in fixing this. So, waiting for another review.

btw: I remembered that we had an issue about python install location, but it was in setup.py configs #206.

@bjsowa
Copy link
Author

bjsowa commented Jan 16, 2026

@christophfroehlich Any chance this gets merged and released soon? I'm getting a lot of spam from ROS buildfarm about failing jobs...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants