Add subtree ports to NodeConfig #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsobek
force-pushed
the
fix-subtree-ports
branch
from
031312d to
2a0f48f
Compare
pac48
reviewed
Jun 26, 2025
pac48
reviewed
Jun 26, 2025
pac48
reviewed
Jun 26, 2025
Author
|
Getting some funky results from this right now still |
dsobek
force-pushed
the
fix-subtree-ports
branch
from
c72b58a to
5596408
Compare
pac48
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #11913
Basically the node config wasn't being populated correctly with the ports, this code is a big bowl of spaghetti and this PR doesn't do much to fix this besides move parsing and validation of ports together (for regular nodes and subtree nodes).