Skip to content

Initial Merge Pull Request#2

Open
MishaSavchenko wants to merge 33 commits intoPhys767-Spring17:masterfrom
MishaSavchenko:master
Open

Initial Merge Pull Request#2
MishaSavchenko wants to merge 33 commits intoPhys767-Spring17:masterfrom
MishaSavchenko:master

Conversation

@MishaSavchenko
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown

@drewjrosen drewjrosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically you need to comment more on everything.

Comment thread Log_of_planck_function.py Outdated
# So logflux (which is what we want) is just the log of this
logflux[i] = logfactor + np.log10(flux[i])
return logflux

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should comment on everything below. Explain more what is going on.

Comment thread Spectral_Radiance.py Outdated
@@ -0,0 +1,54 @@
from __future__ import print_function
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add comments to everything.

…ons with an arbitrary and a calculated burn point
…esult int results.dat, Spectral_radiance uses results.dat to plot last estimate, spectral_radiance.py does the same with some issues
@MishaSavchenko MishaSavchenko self-assigned this Apr 13, 2017
@MishaSavchenko MishaSavchenko requested a review from kelle April 13, 2017 20:32
@MishaSavchenko MishaSavchenko changed the title General Pull Request Initial Merge Pull Request Apr 13, 2017
Copy link
Copy Markdown
Member

@kelle kelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made several comments in line.
also, files in pycache should not be here. Several other students have had all these extra files in their repos as well. Consider asking David for help.

Comment thread .cache/v/cache/lastfailed Outdated
@@ -0,0 +1 @@
{} No newline at end of file
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file should not be tracked by github. (Nothing in the .cache directory should be.)

@@ -0,0 +1,474 @@
{
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure this file shouldn't be tracked either.

Comment thread mcmc_test/Log_of_planck_function.py Outdated
flux=np.empty([len(wavelength)])
logflux=np.empty([len(wavelength)])
for i in range(len(wavelength)):
# Flux is just the Planck function
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete "just".

Comment thread mcmc_test/Log_of_planck_function.py Outdated
for i in range(len(wavelength)):
# Flux is just the Planck function
flux[i] = ( (2.0*con.h*con.c**2)/(wavelength[i]**5) )/( np.exp( (con.h*con.c)/(con.k*Teff*wavelength[i]) ) - 1.0 )
# So logflux (which is what we want) is just the log of this
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete "just". logflux is the log of the Planck function.

Comment thread mcmc_test/Log_of_planck_function.py Outdated

results = ascii.read("results.dat")

T1 = 100
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

T is ambigiusous. temp?

Comment thread mcmc_test/Log_of_planck_function.py Outdated
T3 = 300
MCMC_Temp = results[0][0]

Y1_B = (np.log10(planck(X*10**-6,T1)))
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont know what the code is doing here. what does Y1_B mean?

Comment thread mcmc_test/Log_of_planck_function.py Outdated
Y4_B = (np.log10(planck(X*10**-6,T3)))


x = np.asarray([3.368,4.618,12.082,22.194,3.6,4.5])
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where do these numbers come from?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants