[Vanilla Fix] Aircraft which crash offmap are not properly removed

[CnCRAZER]

This pull request addresses an important bug related to aircraft units destroyed while crashing off the visible map area. Previously, these aircraft were not properly cleaned up, which could permanently block production slots and incorrectly count toward unit limits. The fix ensures that such aircraft are now correctly removed from the game state. The main changes are as follows:

Bug Fixes and Cleanup:

• Added logic in src/Misc/Hooks.BugFixes.cpp to detect aircraft that are destroyed while crashing off-map and force their cleanup by calling UnInit(). This prevents them from blocking production and unit limits.

Documentation Updates:

• Updated docs/Fixed-or-Improved-Logics.md to describe the fix for aircraft destroyed while crashing off-map never being fully cleaned up.
• Updated docs/Whats-New.md to mention the new fix for aircraft cleanup off-map.
• Updated CREDITS.md to credit the contributor for the aircraft cleanup fix.

[github-actions]

Nightly build for this pull request:

• compiled-dll-ecd0a431b498e215187f0492cc81e770ee6b79f9.zip
  These artifacts will expire in 90 days and will not be available for download after that time.

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

[TaranDahl]

What causes off-map or not to have different effects on crash behavior? The position you hooked doesn't seem to have such a difference.

[CnCRAZER]

What causes off-map or not to have different effects on crash behavior? The position you hooked doesn't seem to have such a difference.

AFAIK offmap aircraft types are only removed if they are spawned from spawner or from teamtypes exiting the map. Running uninit to clear the unit from map is also only checked if aircraft type is within radar bounds

[CnCRAZER]

check the discord Phobos chat for the conversation regarding it

[TaranDahl]

Repost:

I checked this. I think the location of the fix in your PR is incorrect.
I believe the root cause of the problem is at 4CD748. If it is outside the map, loco will refuse to set the location. Setting the layer and Mark are also rejected. It is unclear why such a judgment is made.
I think the correct approach should be to make a judgment at 4CD797, treating a crash outside the map the same as touching the ground, and performing subsequent detonation and unit deletion operations.
In addition, I'm afraid the crash of jumpjet has a similar problem (54CBC2). You'd better fix it while you're at it.