Draft
Conversation
This implements the core logic around exposing match states.
This helper handles scheduled and operational delays, rather than us needing to handle each case ourselves.
This was referenced Jan 18, 2026
9c0bbf8 to
a911fd8
Compare
b76443d to
6ac2a92
Compare
This is useful for clients who want to pick up when this changes.
The previous spelling was potentially misleading, especially if data were cached, since the "hold" vs "future" states could change without the state changing. Exposing this simpler value turns out to be all that clients actually need (since they end up doing the time comparison themselves anyway) and avoids introducing time-sensitive data into endpoints which are currently expected to be time-invariant.
6ac2a92 to
ad114d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relies on PeterJCLaw/srcomp#53.