Migrate to ng-mock
#883
Merged
Migrate to ng-mock
#883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slifty
force-pushed
the
879-migrate-to-ng-mocks
branch
from
555318f to
245fe0f
Compare
slifty
force-pushed
the
879-migrate-to-ng-mocks
branch
4 times, most recently
from
08b325a to
c3c009b
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
+ Coverage 47.10% 47.75% +0.65%
==========================================
Files 372 351 -21
Lines 11495 11292 -203
Branches 1914 1889 -25
==========================================
- Hits 5415 5393 -22
+ Misses 5896 5709 -187
- Partials 184 190 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
It passes! I'm going to have Claude attempt to organize things into better clumps of commits that we can review in pieces, and then it's possible would still want to squash them into changes. |
slifty
force-pushed
the
879-migrate-to-ng-mocks
branch
from
c3c009b to
804017f
Compare
aasandei-vsp
approved these changes
Jan 15, 2026
Contributor
aasandei-vsp
left a comment
aasandei-vsp
left a comment
There was a problem hiding this comment.
I ran the tests locally after an npm install and everything passed. Tests look better than before, so it's definitely a step forward.
| ngMocks.globalKeep(NgbDropdownModule); | ||
| ngMocks.globalKeep(NgbPaginationModule); | ||
| ngMocks.globalKeep(CountUpDirective); | ||
| ngMocks.globalKeep(CountUpModule); |
Contributor
There was a problem hiding this comment.
I wonder why we are not mocking these too.
We were using a library called `shallow-render` to help with mocking angular components for our tests. That library is not maintained by a large community, and was falling behind major angular updates. `ng-mocks` is a much more popular library for angular testing. It also provides more functionality beyond just shallow component mocking. Issue #879 Remove shallow-render dependency Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
slifty
force-pushed
the
879-migrate-to-ng-mocks
branch
from
804017f to
b9cea03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes our use of
shallow-renderand replaces it withng-mockwhich is a commonly used mocking library with more community support.This is an extensive set of changes, so it's broken into smaller parts for easier review; ultimately, however, we will want to squash the commits into a single migration commit.
Resolves #879