Skip to content

Feature/engine namespaces 1323#1577

Merged
cromedome merged 3 commits intomainfrom
feature/engine-namespaces-1323
Mar 5, 2026
Merged

Feature/engine namespaces 1323#1577
cromedome merged 3 commits intomainfrom
feature/engine-namespaces-1323

Conversation

@veryrusty
Copy link
Copy Markdown
Member

Draft implementation to allow fully qualified namespaces for all engines, as discussed some time ago in #1323.

Draft PR before I go write more tests / documentation to ensure this is where we want to go:

  set engines => {
    serialier => {
      'My::Awesome::Serializer => { ... },
    },
    template => {
      'My::Template::DWIM => { ... }.
    },
  };
  set serializer => `+My::Awesome::Serializer`;
  set template => `+My::Template::DWIM`;

@veryrusty
Copy link
Copy Markdown
Member Author

@SysPete @racke @cromedome thoughts ?

@racke
Copy link
Copy Markdown
Member

racke commented Jan 13, 2021

Sounds good to me. 👍

@racke
Copy link
Copy Markdown
Member

racke commented Jan 13, 2021

Just make sure that you don't repeat the serialier typo in the documentation.


 set engines => {
    serialier => {
      'My::Awesome::Serializer => { ... },
    },
    template => {
      'My::Template::DWIM => { ... }.
    },
  };

@SysPete
Copy link
Copy Markdown
Member

SysPete commented Jan 13, 2021

@veryrusty 👍 for using + as a FQ namespace indicator as it follows a pattern used elsewhere. Very happy to see this, thank you!

@cromedome
Copy link
Copy Markdown
Contributor

Yes! 👍 I like what you've done here! Please keep running with it.

@xsawyerx
Copy link
Copy Markdown
Member

xsawyerx commented Feb 5, 2026

👍 from me.

@veryrusty veryrusty marked this pull request as ready for review February 7, 2026 23:16
veryrusty and others added 3 commits February 13, 2026 09:10
Similarly to what DBIC allows, the full namespace to any engine can be
specified with a leading `+`. i.e.

  set serialier => '+My::Awesome::Serializer';

will DWIM.
@cromedome cromedome force-pushed the feature/engine-namespaces-1323 branch from c729563 to a7dbf17 Compare February 13, 2026 14:25
@cromedome
Copy link
Copy Markdown
Contributor

Just rebased and added docs for this. Ready to release 👍

@cromedome cromedome merged commit a7dbf17 into main Mar 5, 2026
18 checks passed
@cromedome cromedome deleted the feature/engine-namespaces-1323 branch March 5, 2026 01:45
@cromedome
Copy link
Copy Markdown
Contributor

Merged, thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants