Merged
Conversation
jeltz
requested changes
Feb 23, 2026
Collaborator
jeltz
left a comment
jeltz
left a comment
There was a problem hiding this comment.
Code looks good but I think we need to add something somewhere to explain why this tool exists.
| int ncols = PQnfields(res); | ||
| for (int i = 0; i < ncols; i++) { | ||
| if (i > 0) printf("\t"); | ||
| printf("%s", PQgetvalue(res, 0, i)); |
Collaborator
There was a problem hiding this comment.
Does not matter really but why not use fputs()?
Collaborator
Author
There was a problem hiding this comment.
I simply used printf/fprintf everywhere, no specific reason. I can change it to more specific functions or iostream if you want to, this was just one way to do it.
Compared to psql, which completes the device flow this test executable simply receives a token on the command line, and executes a query. We can also showcase this for the open issue Percona-Lab#27 how using pre obtained tokens is possible.
dutow
force-pushed
the
testexecutable
branch
from
37dcdb6 to
6c089e2
Compare
jeltz
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compared to psql, which completes the device flow this test executable simply receives a token on the command line, and executes a query.
We can also showcase this for the open issue #27 how using pre obtained tokens is possible.