-
Notifications
You must be signed in to change notification settings - Fork 59
Add reference semantics quantum dialect definition #2320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
paul0403
wants to merge
17
commits into
main
Choose a base branch
from
RefQ_dialect_base
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nice!
I'd say we would want conversions in both directions ideally, that way the ref dialect can be used more flexibly. Although the ref->value at least allows us to simplify the frontend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
There will be 3 PRs on reference semantics quantum dialect.
Ideally there will be a fourth PR:
4. A conversion from value dialect to reference dialect.
But depending on time/complexity/workload/priority, we might need to drop some of them this quarter.
Description of the Change:
Here's the list of all operations in the regular quantum dialect that uses
QubitTypeorQuregTypevalues as inputs/outputs:Benefits:
Possible Drawbacks:
Related GitHub Issues:
[sc-105532]