Add compilation support for greater than or equal, less than or equal, and not equal operators#188
Open
GermanCodeEngineer wants to merge 3 commits intoPenguinMod:developfrom
Open
Conversation
…ual operators in ScriptTreeGenerator and JSGenerator
Steve0Greatness
approved these changes
Apr 7, 2026
Steve0Greatness
left a comment
There was a problem hiding this comment.
This mostly seems like a copy-paste of the other blocks, which is fine.
My only issue is that there's a lot of duplicated code in src/compiler/jsgen.js:912-921, but given that seems like an issue with the block it directly states it was based on, I don't think it's a deal breaker.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for Changes and Summary
PenguinMod has six standard comparison operator blocks. Three of these are compiled, three aren't. This pull request implements compilation for the "not equal", "less than or equal" and "greater than or equal" blocks.
I added code to
ScriptTreeGeneratorandJSGeneratorin the same style as their existing code.Test Coverage
I updated
tw-generate-comparison-matrix-inline.jsto also test the new operations. I also improved that script, so one can actually read failed test messages. (looks_saydoesn't give you time to read).I also added the generated XML to a project and ran the tests, which all passed. The created project was added under
tw-generate-comparison-matrix-inline.pmp