Refactor mobile money channel resolution and inject provider per tran…#121
Merged
Peter-John-paystack merged 1 commit intoMay 20, 2026
Merged
Conversation
…saction
Replaces the implicit MPesa-only assumption with an explicit SupportedChannel
model and a configurable provider allowlist on ChargeViewModel. The selected
MobileMoneyChannel is now threaded through ChargePaymentType, MPesaChargeView,
and MPesaChrageViewModel so the charge request uses the chosen provider's key
instead of always picking the first channelOption.
- Adds Sources/PaystackUI/Charge/Models/SupportedChannel.swift with id, title,
and image per channel (card + per-provider mobile money).
- Renames verifyAccessCodeAndProceedWithCard -> verifyAccessCodeAndProceed and
splits it into resolveSupportedChannels / nextState helpers; auto-routes
single-channel cases and falls back to channel selection otherwise.
- Drops the SupportedChannels enum / PaymentChannel wrapper in
ChannelSelectionView in favour of iterating SupportedChannel directly.
- Adds resolver coverage in ChargeViewModelTests (allowlist filtering,
auto-route, channel selection, transactionDetails regression guard) and
updates MPesaChrageViewModelTests to verify the injected provider key is
forwarded to the repository.
|
Peter-John-paystack
requested review from
a team and
michael-paystack
as code owners
zaheer-paystack
approved these changes
May 19, 2026
vusi-paystack
approved these changes
May 19, 2026
Peter-John-paystack
deleted the
feature/Refactor-mobile-money-channel-resolution
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…saction
Replaces the implicit MPesa-only assumption with an explicit SupportedChannel
model and a configurable provider allowlist on ChargeViewModel. The selected
MobileMoneyChannel is now threaded through ChargePaymentType, MPesaChargeView,
and MPesaChrageViewModel so the charge request uses the chosen provider's key
instead of always picking the first channelOption.