Stages for vaal skills#8539
Draft
Blitz54 wants to merge 4 commits intoPathOfBuildingCommunity:devfrom
Draft
Conversation
Blitz54
force-pushed
the
stages-for-skills
branch
from
bc9c774 to
5ff6f36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5698
Description of the problem being solved:
Vaal Blight now has selectable Stages in side bar and Calc page.
Vaal Reave also has Stages in side bar and Calc page.
Vaal Reave and the Reave part of Vaal Reave both scale stacks properly. However, Reave of Refraction only scales to the normal 10 that is possible from a 20q Vaal Reave. Not sure if it's possible, but it would be nice to somehow grab the Vaal Reave max stacks, and apply it to RoR. If the player has enhance linked to the Vaal gem, or has it socketed in Crest of Desire, the stacks would be over 10 and RoR has no idea.
Vaal Blade Flurry also has stages like above.
Vaal Blade Flurry has no cap on the max stages currently. This is because the skill ends once the circle reaches 9m. Increased AoE affects this. With 89% increased AoE in game, it only took 11/12 stages for it to auto end at 9m. Decreased AoE would make the skill hit more stages before 9m. I also am not sure on where to get the secondary radius for the aoe on enemies. I set it to 1m for now.
Vaal Flameblast wasn't applying decreased AoE per stage, it was looking for regular flame blast.
Vaal Flameblast base radius increased to 45, from update 3.14.
Current Issues:
Vaal Blade Flurry applies 50% less damage to player at all times, regardless if it's the active skill. This is in the current release, not from this PR.
Link to a build that showcases this PR:
https://pobb.in/6MwWYCMzXy3M
Before screenshot:
After screenshot: