Add Facebreaker unique gloves support#2097
Open
Anakior wants to merge 2 commits into
Open
Conversation
Contributor
This is incorrect. The API does have this info in the quest field Edit: "quest_stats": [
"\u002B20 to maximum Life",
"5% increased maximum Life",
"5% increased maximum Mana",
"\u002B100 to [Spirit|Spirit]",
"\u002B5% to all [ElementalDamage|Elemental] [Resistances]",
"\u002B15% to [Resistances|Fire Resistance]",
"\u002B15% to [Resistances|Cold Resistance]",
"\u002B15% to [Resistances|Lightning Resistance]",
"30% increased Life Recovery from [Flask|Flasks]",
"30% increased Global [Armour], [Evasion] and [EnergyShield|Energy Shield]",
"25% increased [StunThreshold|Stun Threshold]",
"30% increased [Charm] Charges gained",
"\u002B1 [Charm] Slot",
"57 [BrokenFace|Broken Boss Faces]"
] |
Author
|
Oh ok. I didn't saw that field, thanks a lot ! I have updated the branch to get it from this and auto fill the config but didn't removed it from the config if people want to theorycraft on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Adds Facebreaker and support since i'm playing it for its three modifiers that currently show up as "Not supported in PoB yet":
Has 8 to 12 Physical damage, +3 to +4 per Boss's Face Broken(also the Fire variant)Can Attack as though using a One Handed Mace while both of your hand slots are emptyUnarmed Attacks that would use an Equipped One Hand Mace's damage use this Item's damageSteps taken to verify a working solution:
The "attack as a One Hand Mace while unarmed" bit works like Hollow Palm: when both hands are empty I set
weaponData1.asThoughUsing["One Hand Mace"]in CalcSetup so mace skills become usable. The hits stay unarmed-flagged (it only satisfies the weapon requirement, it doesn't grant mace scaling). The item's base damage is added as flat unarmed damage.The
per Boss's Face Brokenpart is aMultiplier:BossFaceBrokendriven by a new config option ("# of Boss's Faces Broken"), since that count isn't exposed by the character API and has to be entered manually like other "per X" stacks.Also added the unique to Data + Export, regenerated ModCache, and added tests in
spec/System/TestFacebreaker_spec.lua.Screenshot