Skip to content

Adding DPS calculation for Firestorm, Rain of Arrows, Icestorm, Thunderstorm and Volcano#1747

Merged
LocalIdentity merged 6 commits intoPathOfBuildingCommunity:devfrom
MrHB212:firestorm_2
Feb 17, 2026
Merged

Adding DPS calculation for Firestorm, Rain of Arrows, Icestorm, Thunderstorm and Volcano#1747
LocalIdentity merged 6 commits intoPathOfBuildingCommunity:devfrom
MrHB212:firestorm_2

Conversation

@MrHB212
Copy link
Contributor

@MrHB212 MrHB212 commented Jan 23, 2026

Fixes #1740

Description of the problem being solved:

Added relevant statMap for the Mods one impact every x second and can hit enemy only every y seconds and similar.
Also changed a line to set the Flag notAverage for sustained Skills to show DPS calculations.

Before screenshot:

image image

After screenshot:

image image

baseTypeName = "Bloodhound's Mark",
color = 2,
description = "Mark a target, making them suffer Heavy Stun build up from Blood Loss. If they suffer enough Blood Loss while Marked, the Mark will Activate, Consuming itself and releasing an explosion of blood when they are killed or Heavy Stunned. The Mark's duration does not expire while the Marked target is suffering Blood Loss.",
description = "Mark a target, making them suffer Heavy Stun build up from Blood Loss. If they suffer enough Blood Loss while Marked, the Mark will Activate, Consming itself and releasing an explosion of blood when they are killed or Heavy Stunned. The Mark's duration does not expire while the Marked target is suffering Blood Loss.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Consming" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh i have no clue. I have just exported the skills.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, GGG pls!

@MrHB212 MrHB212 marked this pull request as ready for review January 25, 2026 19:02
@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Feb 17, 2026
@LocalIdentity LocalIdentity changed the title Adding DPS calculation for Firestorm and similar skills Adding DPS calculation for Firestorm, Rain of Arrows, Icestorm, Thunderstorm and Volcano Feb 17, 2026
Copy link
Contributor

@LocalIdentity LocalIdentity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to re-run the skill gem exports with updated game files to fix the issues with the files being out of date

@LocalIdentity LocalIdentity merged commit 3dd53c3 into PathOfBuildingCommunity:dev Feb 17, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature, calculation, or mod

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Properly calculate storm skills DPS

3 participants