This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Fix Comparison Tooltip adding Time Lost Jewel mods to incorrect radiusNodes#63
Merged
LocalIdentity merged 4 commits intoPathOfBuildingCommunity:devfrom Jan 19, 2025
Conversation
Peechey
added
technical
Peechey
changed the title
Peechey
changed the title
Peechey
added
bug: behaviour
Peechey
changed the title
Peechey
changed the title
LocalIdentity
merged commit 4f97083
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
When the AddItemTooltip is run for item comparison for a time lost jewel, the mods are being added to all jewels within radius of allocated jewel sockets (familiar beast). This is a quick fix that adds a flag when ItemsTab start the compare to essentially tell the Time Lost logic to not add anything and return the node as is. We lose the compare of what the "also grant" mods would do for that socket but users can always move it themselves for now, and I plan to get a better solution out soon.
Before screenshot:
After screenshot: