This repository was archived by the owner on Oct 21, 2025. It is now read-only.
Fix radius nodes getting incorrect Time-Lost Jewel mods#55
Merged
LocalIdentity merged 1 commit intoPathOfBuildingCommunity:devfrom Jan 19, 2025
Conversation
Peechey
added
bug: behaviour
LocalIdentity
approved these changes
Jan 19, 2025
LocalIdentity
merged commit 47eeb7a
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Peechey
deleted the
fix/fix-which-mods-time-lost-jewels-add-to-radiusNodes
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Time-Lost jewels were adding all of their mods to the radiusNodes when only mods of type "also grant" should be added. Also added a little sanitizing for explicitModLines that are actually two mods in one with a line break.
Still need to work on merging mod values if the mod on the radiusNode matches the mod being added by the jewel, but that could be its own PR as the calculations are correct either way
Link to a build that showcases this PR:
Before screenshot:
After screenshot:
Merging issue example I'm gonna try to figure out
