Update dependency msw to v2.14.6#2992
Merged
Merged
Conversation
While updating, the "selecting history period updates graph values" tests were also simplified. There were previously six near-identical tests, one per history period (1m, 5m, 10m, 15m, 30m, 1h). Since the component uses a single watch on the history period store with no per-period branching logic, a single representative test is sufficient to cover this behaviour. The 1-minute test had also been silently broken: period 1 is the default, so navigating to the endpoint page and then "selecting" 1 minute was a no-op — the store value never changed, the watcher never fired, and no re-fetch occurred. The fix was a test issue only; the application correctly avoids re-fetching when the period hasn't changed.
johnsimons
commented
May 19, 2026
Member
Author
There was a problem hiding this comment.
There were previously six near-identical tests, one per history period (1m, 5m, 10m, 15m, 30m, 1h). Since the component uses a single watch on the history period store with no per-period branching logic, a single representative test is sufficient to cover this behaviour.
The 1-minute test had also been silently broken: period 1 is the default, so navigating to the endpoint page and then "selecting" 1 minute was a no-op — the store value never changed, the watcher never fired, and no re-fetch occurred. The fix was a test issue only; the application correctly avoids re-fetching when the period hasn't changed.
rbev
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per the instructions in #2983
As part of this PR, the "selecting history period updates graph values" tests were also simplified. There were previously six near-identical tests, one per history period (1m, 5m, 10m, 15m, 30m, 1h). Since the component uses a single watch on the history period store with no per-period branching logic, a single representative test is sufficient to cover this behaviour.
The 1-minute test had also been silently broken: period 1 is the default, so navigating to the endpoint page and then "selecting" 1 minute was a no-op — the store value never changed, the watcher never fired, and no re-fetch occurred. The fix was a test issue only; the application correctly avoids re-fetching when the period hasn't changed.
Reviewer Checklist