Skip to content

Update dependency msw to v2.14.6#2992

Merged
johnsimons merged 2 commits into
masterfrom
john/update_msw
May 20, 2026
Merged

Update dependency msw to v2.14.6#2992
johnsimons merged 2 commits into
masterfrom
john/update_msw

Conversation

@johnsimons
Copy link
Copy Markdown
Member

@johnsimons johnsimons commented May 19, 2026

As per the instructions in #2983

As part of this PR, the "selecting history period updates graph values" tests were also simplified. There were previously six near-identical tests, one per history period (1m, 5m, 10m, 15m, 30m, 1h). Since the component uses a single watch on the history period store with no per-period branching logic, a single representative test is sufficient to cover this behaviour.

The 1-minute test had also been silently broken: period 1 is the default, so navigating to the endpoint page and then "selecting" 1 minute was a no-op — the store value never changed, the watcher never fired, and no re-fetch occurred. The fix was a test issue only; the application correctly avoids re-fetching when the period hasn't changed.

Reviewer Checklist

  • Components are broken down into sensible and maintainable sub-components.
  • Styles are scoped to the component using it. If multiple components need to share CSS, then a .css file is created containing the shared CSS and imported into component scoped style sections.
  • Naming is consistent with existing code, and adequately describes the component or function being introduced
  • Only functions utilizing Vue state or lifecycle hooks are named as composables (i.e. starting with 'use');
  • No module-level state is being introduced. If so, request the PR author to move the state to the corresponding Pinia store.

@johnsimons johnsimons requested a review from rbev May 19, 2026 06:48
@johnsimons johnsimons self-assigned this May 19, 2026
@johnsimons johnsimons enabled auto-merge May 19, 2026 06:49
While updating, the "selecting history period updates graph values" tests were also simplified. There were previously six near-identical tests, one per history period (1m, 5m, 10m, 15m, 30m, 1h). Since the component uses a single watch on the history period store with no per-period branching logic, a single representative test is sufficient to cover this behaviour.

The 1-minute test had also been silently broken: period 1 is the default, so navigating to the endpoint page and then "selecting" 1 minute was a no-op — the store value never changed, the watcher never fired, and no re-fetch occurred. The fix was a test issue only; the application correctly avoids re-fetching when the period hasn't changed.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were previously six near-identical tests, one per history period (1m, 5m, 10m, 15m, 30m, 1h). Since the component uses a single watch on the history period store with no per-period branching logic, a single representative test is sufficient to cover this behaviour.

The 1-minute test had also been silently broken: period 1 is the default, so navigating to the endpoint page and then "selecting" 1 minute was a no-op — the store value never changed, the watcher never fired, and no re-fetch occurred. The fix was a test issue only; the application correctly avoids re-fetching when the period hasn't changed.

@johnsimons johnsimons merged commit 3cd5def into master May 20, 2026
5 checks passed
@johnsimons johnsimons deleted the john/update_msw branch May 20, 2026 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants