Skip to content

Add authentication and SSL/TLS to ServicePulse #2729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
warwickschroeder wants to merge 30 commits into
base: master
Choose a base branch
from
Open

Add authentication and SSL/TLS to ServicePulse #2729

warwickschroeder wants to merge 30 commits into from

Conversation

@warwickschroeder
Copy link

@warwickschroeder warwickschroeder commented Nov 24, 2025 •
edited
Loading

Addresses: #1723

  • Supports JWT bearer tokens, OpenID Connect, OAuth2.0.
  • Uses Authorisation Code OAuth2 grant type
  • Authentication config is fed from the ServiceControl API. Defaults to disabled.
  • Adds config for direct HTTPS hosting. Defaults to disabled.
  • Adds config for HTTPS redirect and HSTS
  • Adds config for Forward Headers (reverse proxy). Defaults to "All" headers and "Any" proxies.
  • Add unit and acceptance tests for the windows service (.net framework) host and the container (.net8) host

@jasontaylordev jasontaylordev changed the title Add initial authentication Add initial authentication to ServicePulse Nov 25, 2025
warwickschroeder
warwickschroeder commented Nov 26, 2025
View reviewed changes
@warwickschroeder warwickschroeder force-pushed the genxp-3600-add-authentication branch from da0cc40 to 787ab48 Compare November 26, 2025 07:36
@jasontaylordev jasontaylordev force-pushed the genxp-3600-add-authentication branch 2 times, most recently from 48fcaed to c5d166e Compare December 1, 2025 04:53
@warwickschroeder warwickschroeder changed the title Add initial authentication to ServicePulse Add authentication and SSL/TLS to ServicePulse Dec 10, 2025
@warwickschroeder warwickschroeder marked this pull request as ready for review December 17, 2025 01:10
@jasontaylordev jasontaylordev force-pushed the genxp-3600-add-authentication branch from 559660c to 62dd485 Compare January 8, 2026 06:44
johnsimons and others added 19 commits January 15, 2026 11:56
@johnsimons @warwickschroeder
Replace moment with dayjs
13e5b1b 
This should save ~286KB gzipped
@warwickschroeder
WIP - Add authentication
9ec501e
@jasontaylordev @warwickschroeder
Load OIDC configuration from ServiceControl API instead of local env
919d422
@jasontaylordev @warwickschroeder
Adding support for enabling/disabling authentication
b9d5fff
@warwickschroeder
Add lint rule to check for raw fetch calls.
9f43613
@warwickschroeder
Add user profile menu item. Fix timing issue when SC isnt available. …
9a1cf63 
…Add auth detail loading screen.
@warwickschroeder
Allow multiple api scopes. Add audience config which is needed for so…
607f692 
…me IdPs
@jasontaylordev @warwickschroeder
Package updates
9754f0f
@jasontaylordev @warwickschroeder
Merging
c92d312
@warwickschroeder
Add HTTPS config with documentation
ed1cf35
@warwickschroeder
Update auth and https documentation
8b4b01e
@warwickschroeder
Update doc naming
b4cfcc9
@warwickschroeder
Fix doc namie
fbabd1f
@warwickschroeder
Update auth testing docs. Add anon logout page.
279b0a7
@warwickschroeder
Add authentication tests
d351ecd
@jasontaylordev @warwickschroeder
Update authentication-testing.md
06f8591
@jasontaylordev @warwickschroeder
Fix user profile dropdown appearing behind dashboard items
1dcaca6
@jasontaylordev @warwickschroeder
Doc update
29e1db4
@jasontaylordev @warwickschroeder
Update package-lock.json
d8e968d
@warwickschroeder warwickschroeder force-pushed the genxp-3600-add-authentication branch from 6abcbdc to 477556a Compare January 15, 2026 04:12
@warwickschroeder warwickschroeder mentioned this pull request Jan 19, 2026
Open
abparticular
abparticular reviewed Jan 22, 2026
View reviewed changes
johnsimons
johnsimons reviewed Jan 22, 2026
View reviewed changes
Copy link
Member

@johnsimons johnsimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed the vue code and left a few comments

@warwickschroeder
Update from feedback. Add setting logging. Upgrade SC urls to https i…
7b76e86 
…f https is enabled in SP. Fix forward header bug for .net framework header
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johnsimons johnsimons johnsimons left review comments

@abparticular abparticular abparticular approved these changes

@jasontaylordev jasontaylordev Awaiting requested review from jasontaylordev

Assignees

@jasontaylordev jasontaylordev

@warwickschroeder warwickschroeder

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@warwickschroeder @johnsimons @abparticular @jasontaylordev