Skip to content

Do not return negative throughput when queue table deleted #5404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikeminutillo wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not return negative throughput when queue table deleted #5404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ServiceControl.Transports.SqlServer/QueueTableSnapshot.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ namespace ServiceControl.Transports.SqlServer;

public class BrokerQueueTableSnapshot(BrokerQueueTable details) : BrokerQueueTable(details.DatabaseDetails, details.Schema, details.Name)
{
public long RowVersion { get; set; }
public long? RowVersion { get; set; }
}
11 changes: 7 additions & 4 deletions src/ServiceControl.Transports.SqlServer/SqlServerQuery.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,14 @@ public override async IAsyncEnumerable<QueueThroughput> GetThroughputPerDay(IBro
var endData =
await queueTableName.DatabaseDetails.GetSnapshot(queueTableName, cancellationToken);

yield return new QueueThroughput
if (endData.RowVersion.HasValue && startData.RowVersion.HasValue)
{
DateUTC = DateOnly.FromDateTime(timeProvider.GetUtcNow().DateTime),
TotalThroughput = endData.RowVersion - startData.RowVersion
};
yield return new QueueThroughput
{
DateUTC = DateOnly.FromDateTime(timeProvider.GetUtcNow().DateTime),
TotalThroughput = endData.RowVersion.Value - startData.RowVersion.Value
};
}

startData = endData;
}
Expand Down
Loading