The license status check fails when checking the license against a secured RavenDB instance #5274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mauroservienti
requested review from
DavidBoike,
andreasohlund,
johnsimons and
ramonsmits
johnsimons
reviewed
Jan 22, 2026
src/ServiceControl.Audit.Persistence.RavenDB/LicenseStatusCheck.cs
Outdated
Show resolved
Hide resolved
andreasohlund
approved these changes
Jan 22, 2026
johnsimons
reviewed
Jan 22, 2026
src/ServiceControl.Audit.Persistence.RavenDB/LicenseStatusCheck.cs
Outdated
Show resolved
Hide resolved
mauroservienti
changed the title
ramonsmits
approved these changes
Jan 22, 2026
DavidBoike
approved these changes
Jan 22, 2026
mauroservienti
deleted the
use-internal-raven-client-to-check-for-license
branch
mauroservienti
added a commit
that referenced
this pull request
Jan 22, 2026
…d RavenDB instance (#5274) * Use the internal RavenDB HTTP client * extract the server URL from the document store * Refactor license status check with cancellation token * Fix whitespace * Make the primary instance LicenseStatusCheck behave like the audit instance one --------- Co-authored-by: Ramon Smits <ramon.smits@gmail.com>
mauroservienti
changed the title
Member
Author
|
Backported to 6.9 in #5277 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recently introduced license status check doesn't account for connecting to secured RavenDB servers, such as RavenDB cloud.
This PR changes the way the license status check connects to the RavenDB server. Using the internal RavenDB HTTP Client, the call uses all the preconfigured connection settings, including any authentication configuration. Tested against RavenDB Cloud with certificate authentication.