Split When_sending_within_an_ambient_transaction into two distinct tests and improve done condition#7695
Merged
mauroservienti merged 3 commits intomasterfrom Apr 14, 2026
Merged
Conversation
…sts and improve done condition
danielmarbach
requested review from
DavidBoike,
abparticular,
andreasohlund and
mauroservienti
Contributor
Author
|
FYI @tamararivera |
mauroservienti
approved these changes
Apr 14, 2026
Member
andreasohlund
left a comment
andreasohlund
left a comment
There was a problem hiding this comment.
@danielmarbach updated test names as we discussed
Contributor
Author
|
@andreasohlund LGTM |
mauroservienti
changed the title
When_sending_within_an_ambient_transaction into two distinct tests and improve done condition
mauroservienti
pushed a commit
that referenced
this pull request
Apr 14, 2026
…sts and improve done condition (#7695) * Split When_sending_within_an_ambient_transaction into two distinct tests and improve done condition * Improve naming * Typo --------- Remove attributes Co-Authored-By: Andreas Öhlund <andreas.ohlund@particular.net> Co-Authored-By: Daniel Marbach <daniel.marbach@openplace.net>
danielmarbach
added a commit
that referenced
this pull request
Apr 14, 2026
…sts and improve done condition (#7695) (#7697) * Split When_sending_within_an_ambient_transaction into two distinct tests and improve done condition * Improve naming * Typo --------- Remove attributes Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net> Co-authored-by: Andreas Öhlund <andreas.ohlund@particular.net>
This was referenced Apr 15, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When_sending_within_an_ambient_transactionwas testing two distinct things, and due to that, during the acceptance test done condition refactoring, I missed an overlapping condition. This has caused test failures in three different repositoriesParticular/NServiceBus.Transport.Msmq#891
Particular/NServiceBus.SqlServer#1655
Particular/NServiceBus.NHibernate#1378
This PR splits the test into two distinct tests with corresponding done conditions for the scenarios being tested.