Move endpoint installation to the HostApplicationBuilder level#7691
Closed
DavidBoike wants to merge 7 commits intomasterfrom
Closed
Move endpoint installation to the HostApplicationBuilder level#7691DavidBoike wants to merge 7 commits intomasterfrom
DavidBoike wants to merge 7 commits intomasterfrom
Conversation
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Instead of separate methods for registering endpoints vs. registering endpoint installers, instead this spike shows how installation could be a host-level concern, allowing usage like this:
InstallNServiceBusEndpoints()runsCreate()on the endpoint, and then also forces installers to run, whether or notendpointConfiguration.EnableInstallers()was set, as the settings are finalized when the endpoints are added to the IServiceCollection. No user code or hosted services are run except what would need to be injected into NServiceBus component responsible for installing the endpoint.The implementation calls
builder.Build()and does not return the intermediateIHostso the builder cannot (by design) be used to also attempt to start the endpoints.The result is much less need for testing that, for example, endpoints and installers aren't mixed, or registered as both endpoint and installer, etc.
Currently a little hacky, especially the extent to which forceRunInstallers is pushed through several levels, but I wanted to begin at a layer where the endpoint-specific keyed serviceProvider was already known.