Spike function manifests #17

andreasohlund · 2026-02-10T19:07:32Z

No description provided.

andreasohlund · 2026-02-10T19:08:38Z

@DavidBoike @mattmercurio this seems to work as intended.

andreasohlund · 2026-02-10T19:10:32Z

src/NServiceBus.AzureFunctions.AzureServiceBus/GeneratedCode/FunctionsRegistry.g.cs

+    {
+        entries.Add(new("ReceiverEndpoint", "ReceiverEndpoint", "AzureWebJobsServiceBus"));
+        entries.Add(new("AnotherReceiverEndpoint", "AnotherReceiverEndpoint", "AzureWebJobsServiceBus"));
+    }


If this isn't generated the compiler is smart enough to just remove the call to it https://github.com/Particular/NServiceBus.AzureFunctions/pull/17/changes#diff-ee8c777d474fb183096f7268d8acc6fb6a653a75ef70b7eeba14423385352d0aR10

See https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/keywords/partial-member

A partial method isn't required to have an implementing declaration in the following cases:

It doesn't have any accessibility modifiers (including the default private).
It returns void.
It doesn't have any out parameters.
It doesn't have any of the following modifiers virtual, override, sealed, new, or extern.

andreasohlund · 2026-02-11T09:09:50Z

@DavidBoike @mattmercurio I have rebased and added a few more ideas. See comments inline

andreasohlund · 2026-02-11T09:10:20Z

src/IntegrationTest/Program.cs

+        ConnectionName = "AzureWebJobsServiceBus"
+    };
+
+    var routing = endpoint.UseTransport(transport);


Demo use of routing

andreasohlund · 2026-02-11T09:11:11Z

src/IntegrationTest/Program.cs

 builder.Services.AddHostedService<InitializeLogger>();

-builder.AddNServiceBusFunction("SenderEndpoint", endpoint =>
+builder.AddSendOnlyNServiceBusEndpoint("SenderEndpoint", endpoint =>


Using a separate code path for send-only seems to make validation and other things much cleaner

andreasohlund · 2026-02-11T09:12:16Z

src/IntegrationTest/Program.cs

+    var transport = new AzureServiceBusServerlessTransport(TopicTopology.Default)
+    {
+        //send only endpoints might need to set the connection name
+        ConnectionName = "AzureWebJobsServiceBus"


I think this is the use case where users might want to control the connection name, if so we might want to add this option to AddSendOnlyNServiceBusEndpoint and not on the transport definition

andreasohlund · 2026-02-11T09:12:52Z

src/IntegrationTest/ReceiverEndpoint.cs

    public Task Receiver(
        [ServiceBusTrigger("ReceiverEndpoint", Connection = "AzureWebJobsServiceBus", AutoCompleteMessages = true)]
        ServiceBusReceivedMessage message,
-        ServiceBusMessageActions messageActions, FunctionContext context, CancellationToken cancellationToken = default)


These were leftovers from the old repo and is, at least currently, not needed

andreasohlund · 2026-02-11T09:13:47Z

src/NServiceBus.AzureFunctions.AzureServiceBus/FunctionConfigurationValidator.cs

+
+using Microsoft.Extensions.Hosting;
+
+public class FunctionConfigurationValidator : IHostedService


This makes sure that all functions that we found have been configured by the user

andreasohlund · 2026-02-11T09:14:18Z

src/NServiceBus.AzureFunctions.AzureServiceBus/FunctionsHostApplicationBuilderExtensions.cs

+            configure(endpointConfiguration);
+
+            var settings = endpointConfiguration.GetSettings();
+            if (settings.GetOrDefault<bool>(AzureServiceBusServerlessTransport.SendOnlyConfigKey))


Since we have a separate code path for send-only we can guard here

andreasohlund · 2026-02-11T09:14:50Z

src/NServiceBus.AzureFunctions.AzureServiceBus/FunctionsHostApplicationBuilderExtensions.cs

+
+            var functionManifest = FunctionsRegistry.GetAll().SingleOrDefault(f => f.Name.Equals(endpointName, StringComparison.InvariantCultureIgnoreCase));
+
+            if (functionManifest is null)


Since send only is on a different code path we must have a correcsponding function at this stage

andreasohlund · 2026-02-11T09:15:29Z

src/NServiceBus.AzureFunctions.AzureServiceBus/FunctionsHostApplicationBuilderExtensions.cs

+            endpointConfiguration.SendOnly();
+
+            // Make sure that the correct transport is used
+            _ = GetTransport(endpointConfiguration.GetSettings());


Ugly but gets the job done for now to make sure that the user has configured a AzureServiceBusServerlessTransport

andreasohlund · 2026-02-11T09:16:18Z

src/NServiceBus.AzureFunctions.AzureServiceBus/MessageProcessor.cs

        await endpointStarter.GetOrStart(cancellationToken).ConfigureAwait(false);
-        await transport.MessageProcessor.Process(message, messageActions, cancellationToken).ConfigureAwait(false);
+
+        if (transport.MessageProcessor is null)


In this new world we can never come here unless the user has configured a non-send-only endpoint but we are guaarding anyway for completeness

andreasohlund · 2026-02-11T12:58:09Z

src/NServiceBus.AzureFunctions.AzureServiceBus/GeneratedCode/FunctionsRegistry.g.cs

@@ -0,0 +1,12 @@
+namespace NServiceBus;
+
+static partial class FunctionsRegistry


@DavidBoike now I get what you meant yesterday, this code will be generated in the user assembly and not here so this won't work.

I have another idea, stay tuned

internalautomation bot assigned andreasohlund Feb 10, 2026

andreasohlund requested review from DavidBoike and mattmercurio February 10, 2026 19:07

andreasohlund commented Feb 10, 2026

View reviewed changes

andreasohlund added 2 commits February 11, 2026 08:36

Spike function manifests

cc5644c

Rebase and refactor to get transport from settings

d8b8b1f

andreasohlund force-pushed the function-manifests branch from d033c03 to d8b8b1f Compare February 11, 2026 07:51

andreasohlund added 5 commits February 11, 2026 09:40

Separate code path for send only

06441cc

Hook up the function manifest again

91d6e01

Demo potential place where we need to set the connection name

06b5ae0

Demo routing

d1a1616

Validate that all functions have been configured

f9c4137

andreasohlund commented Feb 11, 2026

View reviewed changes

andreasohlund added 3 commits February 11, 2026 13:03

Handle case where user has disabled the generator

0ca7748

Fixup

cd1fe8e

Cleanup

de0ed25

andreasohlund commented Feb 11, 2026

View reviewed changes


		using Microsoft.Extensions.Hosting;

		public class FunctionConfigurationValidator : IHostedService


		var functionManifest = FunctionsRegistry.GetAll().SingleOrDefault(f => f.Name.Equals(endpointName, StringComparison.InvariantCultureIgnoreCase));

		if (functionManifest is null)

		@@ -0,0 +1,12 @@
		namespace NServiceBus;

		static partial class FunctionsRegistry

Spike function manifests #17

Are you sure you want to change the base?

Spike function manifests #17

Uh oh!

Conversation

andreasohlund commented Feb 10, 2026

Uh oh!

andreasohlund commented Feb 10, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreasohlund Feb 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andreasohlund commented Feb 11, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

andreasohlund Feb 10, 2026 •

edited

Loading