Skip to content

Code analysis fixes #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bording merged 3 commits into from
Feb 13, 2025
Merged

Code analysis fixes #883

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
937754e
Code analysis fixes
DavidBoike Feb 13, 2025
b6ee368
Sorting
DavidBoike Feb 13, 2025
6a08bc3
Tweaks
bording Feb 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ jobs:
- name: Setup .NET SDK
uses: actions/setup-dotnet@v4.3.0
with:
dotnet-version: 8.0.x
dotnet-version: |
8.0.x
6.0.x
- name: Setup Azure Functions Core Tools - Windows
if: runner.os == 'Windows'
run: |
Expand Down
4 changes: 4 additions & 0 deletions src/IntegrationTests.HostV4/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
[*.cs]

# ConfigureAwait(false)
dotnet_diagnostic.CA2007.severity = none
8 changes: 0 additions & 8 deletions src/IntegrationTests.HostV4/GlobalSuppressions.cs
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions src/NServiceBus.AzureFunctions.Analyzer.Tests/.editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
[*.cs]

# ConfigureAwait(false)
dotnet_diagnostic.CA2007.severity = none

# Use pattern matching (may change code meaning)
dotnet_diagnostic.IDE0078.severity = none

# Use pattern matching
dotnet_diagnostic.IDE0083.severity = none

# Convert switch statement to expression
dotnet_diagnostic.IDE0066.severity = none
11 changes: 0 additions & 11 deletions src/NServiceBus.AzureFunctions.Analyzer.Tests/GlobalSuppressions.cs
View file
Open in desktop

This file was deleted.

2 changes: 0 additions & 2 deletions ...ServiceBus.AzureFunctions.Analyzer.Tests/NServiceBus.AzureFunctions.Analyzer.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@

<PropertyGroup>
<TargetFramework>net6.0</TargetFramework>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\NServiceBusTests.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup>
Expand Down
2 changes: 1 addition & 1 deletion src/NServiceBus.AzureFunctions.Analyzer/NServiceBus.AzureFunctions.Analyzer.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@
</PropertyGroup>

<ItemGroup>
<PackageReference Include="Particular.Packaging" Version="4.2.0" PrivateAssets="All" />
<!-- this package can only be upgraded when we drop support for older versions of Visual Studio -->
<PackageReference Include="Microsoft.CodeAnalysis.CSharp.Workspaces" Version="3.11.0" />
<PackageReference Include="Particular.Packaging" Version="4.2.0" PrivateAssets="All" />
</ItemGroup>

<Target Name="UseMajorMinorPatchForAssemblyVersion" AfterTargets="MinVer">
Expand Down
4 changes: 2 additions & 2 deletions ...zureFunctions.InProcess.ServiceBus/NServiceBus.AzureFunctions.InProcess.ServiceBus.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
<ItemGroup>
<PackageReference Include="Microsoft.Azure.Functions.Extensions" Version="1.1.0" />
<PackageReference Include="Microsoft.Azure.WebJobs.Extensions.ServiceBus" Version="5.16.4" />
<PackageReference Include="NServiceBus.Newtonsoft.Json" Version="3.0.0" />
<PackageReference Include="NServiceBus" Version="8.2.4" />
<PackageReference Include="NServiceBus.Newtonsoft.Json" Version="3.0.0" />
<PackageReference Include="NServiceBus.Transport.AzureServiceBus" Version="3.2.5" />
<PackageReference Include="Obsolete.Fody" Version="5.3.0" PrivateAssets="All" />
<PackageReference Include="Particular.Packaging" Version="4.2.0" PrivateAssets="All" />
Expand All @@ -36,8 +36,8 @@
</Target>

<ItemGroup>
<InternalsVisibleTo Include="ServiceBus.Tests" Key="$(NServiceBusTestsKey)" />
<InternalsVisibleTo Include="ServiceBus.AcceptanceTests" Key="$(NServiceBusTestsKey)" />
<InternalsVisibleTo Include="ServiceBus.Tests" Key="$(NServiceBusTestsKey)" />
</ItemGroup>

</Project>