Skip to content

Update to NServiceBus 9#866

Merged
andreasohlund merged 30 commits intomasterfrom
nsb9
Feb 14, 2025
Merged

Update to NServiceBus 9#866
andreasohlund merged 30 commits intomasterfrom
nsb9

Conversation

@bording
Copy link
Member

@bording bording commented Nov 27, 2024

This PR updates the repo to a new major version that works with NServiceBus 9.

It also makes changes to combine analyzer and source generator projects, similar to the changes made to the Worker package: Particular/NServiceBus.AzureFunctions.Worker.ServiceBus#391

@andreasohlund
Copy link
Member

Looking at the logs the only thing that looks odd is https://github.com/Particular/NServiceBus.AzureFunctions.InProcess.ServiceBus/pull/866/checks#step:12:135

but then later we can see that the HTTP request to initiate the test works but then nothing more happens. Is it possible to check if there are some messages in the servicebus namespace used by the test?

@andreasohlund
Copy link
Member

I can repro this locally. The httptrigger is invoked and I can see a message in the input queue but it doesn't get processed so it seems like the binding isn't triggering a receive of the message.
I'll keep digging

@andreasohlund
Copy link
Member

Seems like things start up but the generated servicebus trigger is not detected.

@andreasohlund
Copy link
Member

On master it does get picked up:

Functions:

        InProcessHttpSenderV4: [GET,POST] http://localhost:7071/api/InProcessHttpSenderV4

        NServiceBusFunctionEndpointTrigger-InProcess-HostV4: serviceBusTrigger

but not on this branch

Functions:

        InProcessHttpSenderV4: [GET,POST] http://localhost:7071/api/InProcessHttpSenderV4

@bording bording force-pushed the nsb9 branch 2 times, most recently from 5ba447c to fe271c1 Compare December 9, 2024 17:32
@bording bording marked this pull request as ready for review December 9, 2024 17:41
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 11, 2025
@bording bording removed the stale label Jan 11, 2025
@github-actions
Copy link

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 11, 2025
@bording bording removed the stale label Feb 11, 2025
@andreasohlund
Copy link
Member

The emulator fails with

[2025-02-14T06:48:30.955Z] Microsoft.Azure.WebJobs.Host: Error indexing method 'NServiceBusFunctionEndpointTrigger-InProcess-HostV4'. System.Private.CoreLib: Could not load file or assembly 'System.Memory.Data, Version=6.0.0.0, Culture=neutral, PublicKeyToken=cc7b13ffcd2ddd51'. The system cannot find the file specified.

So it seems like something is still referencing net6?

@andreasohlund
Copy link
Member

Seems to be Azure/azure-functions-host#10575

I have applied the mentioned workaround

@andreasohlund andreasohlund merged commit b67f51a into master Feb 14, 2025
4 checks passed
@andreasohlund andreasohlund deleted the nsb9 branch February 14, 2025 07:32
@bording bording added this to the 5.0.0 milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants