Fix #1305: Enable BOM sorting on part fields (Storage location, Manufacturing status) and fix BOM table query/pagination issues#1338
Open
mkne wants to merge 11 commits intoPart-DB:masterfrom
Open
Fix #1305: Enable BOM sorting on part fields (Storage location, Manufacturing status) and fix BOM table query/pagination issues#1338mkne wants to merge 11 commits intoPart-DB:masterfrom
mkne wants to merge 11 commits intoPart-DB:masterfrom
Conversation
…': Error: 'storageLocations' is not defined." when trying to sort by column Storage Locations
… using association part not allowed." when opening BOM
…\PartLot using association part not allowed." when opening BOM" This reverts commit 5c5c7ce.
… using association part not allowed." when opening BOM 2nd try
….php and PartsDataTable.php
…torage location, manufacturing status
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1338 +/- ##
============================================
- Coverage 56.39% 56.29% -0.11%
- Complexity 8345 8347 +2
============================================
Files 612 612
Lines 26801 26846 +45
============================================
- Hits 15115 15112 -3
- Misses 11686 11734 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors ProjectBomEntriesDataTable to use the same robust two-step query strategy as PartsDataTable, resolving multiple query/pagination errors on the BOM page and restoring expected column behavior.
What changed
Why
The previous single-query fetch-join approach caused Doctrine/PgSQL failures such as:
Using TwoStepORMAdapter avoids these fetch-join pagination pitfalls and keeps sorting/filtering functional.
User-visible impact
Testing performed
Disclaimer: This description was written by Codex but manually edited and corrected.