Add manual backup creation and delete buttons to Update Manager#1255
Open
Sebbeben wants to merge 1 commit intoPart-DB:masterfrom
Open
Add manual backup creation and delete buttons to Update Manager#1255Sebbeben wants to merge 1 commit intoPart-DB:masterfrom
Sebbeben wants to merge 1 commit intoPart-DB:masterfrom
Conversation
- Add "Create Backup" button in the backups tab for on-demand backups - Add delete buttons (trash icons) for update logs and backups - New controller routes with CSRF protection and permission checks - Use data-turbo-confirm for CSP-safe confirmation dialogs - Add deleteLog() method to UpdateExecutor with filename validation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1255 +/- ##
============================================
- Coverage 54.77% 54.67% -0.11%
- Complexity 8012 8028 +16
============================================
Files 601 601
Lines 25690 25736 +46
============================================
- Hits 14072 14070 -2
- Misses 11618 11666 +48 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I've seen discussions about adding a backup button, so I added one to the Update Manager. Also thought it would be useful to easily delete old backups and logs.
@system.manage_updatespermission checksdata-turbo-confirmfor CSP-safe confirmation dialogs (no inline JS)Testing done
@system.manage_updatespermission