Conversation
6c29432 to
09738bf
Compare
|
@jbtronics, I've rebased the branch to the master branch. It would be great if you could take a look at the pull request and give me some feedback on what else needs to be done for you to integrate it. I wish you even now a nice and fulfilling holiday season! Best regards, |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #1082 +/- ##
============================================
- Coverage 54.77% 52.52% -2.25%
- Complexity 8012 8580 +568
============================================
Files 601 629 +28
Lines 25691 27807 +2116
============================================
+ Hits 14073 14607 +534
- Misses 11618 13200 +1582 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I do not quite understand what the semantic difference between an assembly and the existing projects should be? |
|
Hello @jbtronics, I hope you had a wonderful holiday season. Here's the explanation:
With assemblies: The user defines the "Motor" assembly once and the "Control" assembly once with all the depending structure. The difference lies in the level of abstraction: Assemblies thus specifically solve the problem of reusing blueprints, while projects solve the problem of inventory changes during manufacturing. |
|
Im still not really convinced that introducing a new kind of entity is the best approach there. Especially as this PR is very big and complex (136 file changes) and a lot of logic seems to be duplicated from projects. Maybe the goal could also be reached by adding some new functionality to the existing projects (like adding a flag, that makes them non-buildable and only work as generic placeholder, or assembly if you wanna call it that way). I am not sure how many people would actually profit from that feature anyway, and if it is worth to the additional complexity/maintenance effort of the PR in the current form. |
ebb8a2b to
1464c37
Compare
Fügt Unterstützung für Assembly-Filter in der Suche sowie ein neues Tab für Assemblies in der Filteransicht hinzu. Anpassungen beinhalten Änderungen an Datenbankabfragen, Formularen und Templates.
Verbessert die Präzision der Übersetzungen für 'assembly_bom_entry' in mehreren Sprachen. Ergänzt neue Label- und Pluralformen in den Dateien sowie zugehörige Zuordnungen in Klassen.
…ion für Tests aktualisieren Fügt Standardwerte für autowire und autoconfigure in der Testumgebung hinzu. Markiert EntityExporter als öffentlich und bereinigt die Konstruktor-Definition in der zugehörigen Klasse.
…erarbeiten bzw. erweitern
1464c37 to
4b6018f
Compare
|
Hello @jbtronics, thank you for your reply. I don't currently see this being represented in the projects via a flag or similar. Benefits for the community: In addition, a separate assembly entity is certainly more intuitive for such users, as assemblies often serve as reusable blueprints (templates), while projects are one-time instances (actually real orders in a way). I would greatly appreciate it if you could take on this task as well and would also be happy to contribute further to any future inquiries that may arise, because I enjoy doing so. I will also modify the Custom Part State feature to include multiple selection in the near future and prepare it as a pull request—unfortunately, I haven't had time to do so yet ;) Best regards, |
Hello @jbtronics,
In relation to #1051 the feature for adding the base of assembly as an new data source.
Also mentioned in the discussion under #1041, section 1.
The changes are the remaining delta to the other extracted feature pull requests related to the mentioned discussion.
Configuration opportunity of Bills of Materials (BOMs) with referencing of other assemblies, cycle prevention included
Simplified import overview with template description for filling the parts lists (BOM) of an assembly
Human-readable export in CSV and PDF format for simplified viewing of basic information
Human-readable export in PDF format to simplify understanding of which parts are actually required for a multiply nested assembly, for example, completely independent of a build function as is the case with projects.
Thanks for everything so far! I am grateful for integration!
Best regards,
Marcel