Add video to website #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
src/components/video-demo.js
Outdated
| <Box id={'video-demo'} as='section' my={12}> | ||
| <Container maxW='container.lg' centerContent> | ||
| <Heading as='h1' size='2xl' mb={4}> | ||
| Video Demonstration |
Member
There was a problem hiding this comment.
Or "Getting started with the VirtualShip "? It's obvious that's it's a video, so that word doesn't need to be in the title. And the first frame already has "QuickStart guide", so that is also clear
Collaborator
Author
There was a problem hiding this comment.
Yes, that's much better, thanks!
Member
|
Looks very good; just one suggestion for an alternative title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added the VirtualShip quickstart video to the website, under a "Video Demonstration" section. It made most sense to me to place it here, but let me know if it would be better somewhere else on the website. Or indeed if there's a better section title?