Adding the round_and_hash_float_array also to v3 #2156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can easily compare unit test results between v3 and v4
VeckoTheGecko
approved these changes
Aug 22, 2025
Contributor
There was a problem hiding this comment.
LGTM. Though if we want to
unit test results between v3 and v4.
we of course also need to identify tests that we want to use for this comparison. The test suites have diverged quite a bit - but I imagine you already have some tests in mind @erikvansebille ? Also, we have the saved outputs introduced in ffb2fca and used in tests/v4/test_interpolation.py - but I assume you want to expand the comparison to other parts in the codebase?
Member
Author
|
Exactly! I needed this function when working on #2152, and can imagine it's good to have when we port over other functionality and unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
tests/utils.round_and_hash_float_array()function also to v3, so we can easily compare unit test results between v3 and v4.mainfor v3 changes,v4-devfor v4 changes)