Reset max health attribute on server switch#515
Open
kennytv wants to merge 1 commit intoPaperMC:masterfrom
Open
Reset max health attribute on server switch#515kennytv wants to merge 1 commit intoPaperMC:masterfrom
kennytv wants to merge 1 commit intoPaperMC:masterfrom
Conversation
Contributor
|
While we are on this subject, shouldn't JoinGame be resent if the next server is != the same mode (hardcore or not hardcore) ? |
Janmm14
reviewed
Nov 3, 2020
| + public static EntityAttributes createDefaultHealth(int entityId, int protocolVersion) | ||
| + { | ||
| + EntityAttributes packet = new EntityAttributes( entityId ); | ||
| + String key = "generic.maxHealth"; //TODO Differentiate for 1.16: minecraft:generic.max_health |
Contributor
There was a problem hiding this comment.
I think that todo should be solved before merge. shouldn't be hard as the method already gets the protocolVersion.
Contributor
This is already done if you enable the option "disableEntityMetadataRewrite" in Waterfall. It should also be checked if that does reset the client's max health, in that caser this patch would need additional ifs so we don't send it if its not actually needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attributes aren't reset, so the player sees the wrong amount of hearts when switching away from a server that changed the default value to a server without the change (since default attributes are not sent to the client). All of the other attributes either don't affect the client itself or are reset due to non-default values for players, so only the max health attribute is important.