Skip to content

Remove already fixed vanilla bug MC-244739#13787

Open
Doc94 wants to merge 1 commit intoPaperMC:mainfrom
Doc94:feature/remove-already-fixed-MC-244739
Open

Remove already fixed vanilla bug MC-244739#13787
Doc94 wants to merge 1 commit intoPaperMC:mainfrom
Doc94:feature/remove-already-fixed-MC-244739

Conversation

@Doc94
Copy link
Copy Markdown
Member

@Doc94 Doc94 commented Apr 13, 2026

Since 1.21.2 this bug was fixed in vanilla then this change its not necesary.
I test the removed change and the sound still played.

@Doc94 Doc94 requested a review from a team as a code owner April 13, 2026 19:07
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Apr 13, 2026
@Warriorrrr
Copy link
Copy Markdown
Member

You can still hear the sound without this change since it's actually always being played twice, Animal#mobInteract also plays the eating sound when the item is consumed and is food. Maybe now we can add a false && to this if?

@Doc94
Copy link
Copy Markdown
Member Author

Doc94 commented Apr 13, 2026

You can still hear the sound without this change since it's actually always being played twice, Animal#mobInteract also plays the eating sound when the item is consumed and is food. Maybe now we can add a false && to this if?

well the playSound in goat only its called for InteractionResult.CONSUME and that happen in SinglePlayer only then i dont think need that change here.

@Warriorrrr
Copy link
Copy Markdown
Member

InteractionResult#consumesAction is also true for SUCCESS and SUCCESS_SERVER though

@Doc94
Copy link
Copy Markdown
Member Author

Doc94 commented Apr 13, 2026

InteractionResult#consumesAction is also true for SUCCESS and SUCCESS_SERVER though

True.. then not sure why i cannot hear two times the sound when try in vanilla or server (with the patch removed)

@Warriorrrr
Copy link
Copy Markdown
Member

I could only really notice it when stepping through with a debugger, if it's not really possibly to hear it otherwise then I guess this won't need any further changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

2 participants