Skip to content

Prevent NPE on ThrownPotion#splash#13683

Open
SoSeDiK wants to merge 2 commits intoPaperMC:mainfrom
SoSeDiK:npe
Open

Prevent NPE on ThrownPotion#splash#13683
SoSeDiK wants to merge 2 commits intoPaperMC:mainfrom
SoSeDiK:npe

Conversation

@SoSeDiK
Copy link
Contributor

@SoSeDiK SoSeDiK commented Mar 7, 2026

ThrownPotion#splash calls internal splash with null hit result:

@Override
public void splash() {
this.getHandle().splash(null);
}

Which leads to NPE in case of thrown non-water splash potions. Other parts of code expect and handle nullability, but this one was missed.

@SoSeDiK SoSeDiK requested a review from a team as a code owner March 7, 2026 12:08
@github-project-automation github-project-automation bot moved this to Awaiting review in Paper PR Queue Mar 7, 2026
@Lulu13022002 Lulu13022002 linked an issue Mar 7, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Awaiting review

Development

Successfully merging this pull request may close these issues.

ThrownPotion#splash causes a NPE

2 participants